Fix Successful login being logged before login was successful#2003
Open
johanib wants to merge 1 commit into
Open
Fix Successful login being logged before login was successful#2003johanib wants to merge 1 commit into
johanib wants to merge 1 commit into
Conversation
johanib
force-pushed
the
feature/1742-consent-login-logfix
branch
2 times, most recently
from
60f516f to
4b0f4f5
Compare
Prior to this change, the logs logged `login granted` during the assertionConsumerService phase, before consent was given. This happened because the Success log was implemented as a output filter. This is no problem on its own, but, when the `run_all_manipulations_prior_to_consent` feature is enabled, the output filters are performed before consent is handled. This caused the Log line to be logged before the consent was handled. This change removes the LogLogin output filter and moves the code to a separate log fuction, to be called from the correct step in the flow. Fixes #1742
johanib
force-pushed
the
feature/1742-consent-login-logfix
branch
from
4b0f4f5 to
4b3ab73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, the logs logged
login grantedduring the assertionConsumerService phase, before consent was given. This happened because the Success log was implemented as a output filter. This is no problem on its own, but, when therun_all_manipulations_prior_to_consentfeature is enabled, the output filters are performed before consent is handled. This caused the Log line to be logged before the consent was handled.This change removes the LogLogin output filter and moves the code to a separate log fuction, to be called from the correct step in the flow.
Fixes #1742