Skip to content

Issue-1980 remove openconext theme#1994

Merged
johanib merged 7 commits into
mainfrom
feature/issue-1980-remove-openconext-theme
May 18, 2026
Merged

Issue-1980 remove openconext theme#1994
johanib merged 7 commits into
mainfrom
feature/issue-1980-remove-openconext-theme

Conversation

@kayjoosten
Copy link
Copy Markdown
Contributor

No description provided.

@kayjoosten kayjoosten requested a review from johanib May 8, 2026 11:05
@johanib johanib linked an issue May 11, 2026 that may be closed by this pull request
@johanib
Copy link
Copy Markdown
Contributor

johanib commented May 11, 2026

theme/README.md

still references the deleted theme.

@kayjoosten kayjoosten force-pushed the feature/issue-1980-remove-openconext-theme branch from 4c97c11 to dc9844d Compare May 12, 2026 07:48
#!/usr/bin/env bash
set -euo pipefail

THEME=${EB_THEME:-openconext}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could argue that the fallback / default should be 'base' instead of 'skeune'. (not saying this is the case per se).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed: Not for now.

@johanib johanib force-pushed the feature/issue-1980-remove-openconext-theme branch from a528363 to 8afa9cb Compare May 18, 2026 09:48
@johanib johanib merged commit 60c9da5 into main May 18, 2026
2 checks passed
@johanib johanib deleted the feature/issue-1980-remove-openconext-theme branch May 18, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repair or delete OpenConext theme

2 participants