Fix Guzzle regression: Error log was truncated / http exception not caught#1963
Open
Fix Guzzle regression: Error log was truncated / http exception not caught#1963
Conversation
…aught Guzzle 7 renamed the option that disables automatic exception throwing for 4xx/5xx responses from 'exceptions' to 'http_errors'. The old key was silently ignored, leaving Guzzle's httpErrors middleware active. This caused GuzzleHttp\Exception\ClientException to be thrown for any non-2xx response instead of returning the response object for the caller to inspect. In practice this meant that a 400 Bad Request from the attribute aggregation API (AA) was never caught by AttributeAggregator's HttpException handler and propagated as an uncaught CRITICAL-level exception. The exception message was truncated in the logs because Guzzle's BodySummarizer only includes the first 120 characters of the response body when building the ClientException message string.
kayjoosten
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guzzle 7 renamed the option that disables automatic exception throwing for 4xx/5xx responses from 'exceptions' to 'http_errors'. The old key was silently ignored, leaving Guzzle's httpErrors middleware active. This caused GuzzleHttp\Exception\ClientException to be thrown for any non-2xx response instead of returning the response object for the caller to inspect.
In practice this meant that a 400 Bad Request from the attribute aggregation API (AA) was never caught by AttributeAggregator's HttpException handler and propagated as an uncaught CRITICALlevel exception. The exception message was truncated in the logs because Guzzle's BodySummarizer only includes the first 120 characters of the response body when building the ClientException message string.