Open
Conversation
- Rename Dockerfile-php82 → Dockerfile-php85, use php85-apache2-node24 base image - Rename docker-compose-php82.yml → docker-compose-php85.yml - Update Dockerfile.prod to php85-apache2 - Update docker-compose-tag-release.yml to php85-apache2-node24 - Bump composer.json PHP constraint to ^8.5, run composer update - Run yarn upgrade for Node 24 compatibility - Update GitHub Actions matrix and PROD_PHP to php85 Fixes #1847
Apply ExplicitNullableParamTypeRector across src/, library/ and tests/ to replace implicit nullable params (Foo $x = null) with explicit nullable types (?Foo $x = null), fixing the PHP 8.5 deprecation that was crashing the PHPUnit bootstrap. 794 PHPUnit tests passing on PHP 8.5 after this change.
- Bindings.php: replace null array key with empty string - NameIdResolver.php: cast spId/idpId to string before session access - XmlToArray.php: remove xml_parser_free() deprecated since PHP 8.5 All 277 Behat scenarios now pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.