Skip to content

Fix typo + inconsistency #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tvdijen wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix typo + inconsistency #1894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b1e744
Fix typo + inconsistency
tvdijen Nov 29, 2025
e650852
Fix unit tests
tvdijen Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/OpenConext/EngineBlockFunctionalTestingBundle/Features/AcsTinkering.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Feature:
In order to prevent XSS attacks
As a user
I need EB to filter malicious asc values in AuthnRequests
I need EB to filter malicious ACS values in AuthnRequests

Background:
Given an EngineBlock instance on "dev.openconext.local"
Expand All @@ -10,8 +10,8 @@ Feature:
And an Identity Provider named "AlwaysAuth"
And a Service Provider named "Malicious SP"
And a Service Provider named "Malconfigured SP"
And SP "Malicious SP" is set with acs location "javascript:alert('Hello world')"
And SP "Malconfigured SP" is set with acs location "sp.example.com"
And SP "Malicious SP" is set with ACS location "javascript:alert('Hello world')"
And SP "Malconfigured SP" is set with ACS location "sp.example.com"

Scenario: The Malicious SP AuthnRequest is denied by EngineBlock
Given I log in at "Malicious SP"
Expand Down
2 changes: 1 addition & 1 deletion src/OpenConext/EngineBlockFunctionalTestingBundle/Features/Context/MockSpContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ public function spSignsItSRequests($spName)
}

/**
* @Given /^SP "([^"]*)" is set with acs location "([^"]*)"$/
* @Given /^SP "([^"]*)" is set with ACS location "([^"]*)"$/
*/
public function spConfiguredWithAcsLocation($spName, $acsLocation)
{
Expand Down