Add small MariaDB docker role, for running on a single node #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartje
force-pushed
the
feature/mariadb_docker
branch
from
f92e65d to
4d17265
Compare
baszoetekouw
requested changes
Dec 2, 2024
| state: started | ||
| networks: | ||
| - name: "loadbalancer" | ||
| networks: "{{ aa_docker_networks }}" |
Member
There was a problem hiding this comment.
Je vervangt hierdoor de list door een hash. Moet de default niet zijn:
aa_docker_networks:
- name: loadbalancer
Contributor
Author
There was a problem hiding this comment.
Klopt. Het aardige is dat het wel gewoon werkt, alles op TEST is met deze branch gedeployed :)
roles/engineblock/defaults/main.yml
Outdated
|
|
||
| engine_php_memory: 256M | ||
| engine_docker_networks: | ||
| name: loadbalancer |
| # Override is in the dockerX.env host_var files | ||
| invite_cronjobmaster: true | ||
| invite_docker_networks: | ||
| - name: loadbalancer |
| verify_ssl: true | ||
| invite: | ||
| url: 'https://invite.{{ base_domain }}/api/' | ||
| url: 'https://invite.{{ base_domain }}/api/external/v1/' |
Member
There was a problem hiding this comment.
dit lijtk een ongerelateerde change. Is dat bewust?
roles/manage/defaults/main.yml
Outdated
| - provisioning | ||
| - sram | ||
| manage_docker_networks: | ||
| name: loadbalancer |
| @@ -0,0 +1,2 @@ | |||
| gateway_docker_networks: | |||
| name: loadbalancer | |||
Member
There was a problem hiding this comment.
dit moet weer een list zijn
| @@ -0,0 +1,2 @@ | |||
| middelware_docker_networks: | |||
| name: loadbalancer | |||
|
|
||
| - name: Include vm tasks when running on a vm | ||
| include_tasks: vm.yml | ||
| when: "'docker' not in group_names" |
roles/stepuptiqr/defaults/main.yml
Outdated
| @@ -0,0 +1,2 @@ | |||
| tiqr_docker_networks: | |||
| name: loadbalancer | |||
| @@ -0,0 +1,2 @@ | |||
| webauthn_docker_networks: | |||
| name: loadbalancer | |||
internal Docker network to connect to a local MariaDB host in Docker
quartje
force-pushed
the
feature/mariadb_docker
branch
from
4d17265 to
ec01572
Compare
Contributor
Author
|
All network definitions in the defaults are lists now, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The role mariadbdocker is added, which provisions a MariaDB docker container on the Docker host. It allows for hosting all MariaDB databases.
A docker network is created, and all roles that require MariaDB access have access to this network