Feature/eb to docker #458
Merged
Feature/eb to docker #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijskh
reviewed
Nov 20, 2024
thijskh
approved these changes
Nov 20, 2024
Member
thijskh
left a comment
thijskh
left a comment
There was a problem hiding this comment.
The role now no longer executes migrations, so there needs to be some kind of other solution for migrating if this is merged. Otherwise looks good 👍
quartje
force-pushed
the
feature/eb_to_docker
branch
2 times, most recently
from
bcc1797 to
69e77f2
Compare
engineblock on seperate docker hosts
quartje
force-pushed
the
feature/eb_to_docker
branch
from
69e77f2 to
10354e7
Compare
Contributor
Author
As discussed, a generic role will be made to do migrations, reusable for all symfony apps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR transforms the VM based installation of Docker to a Docker based installation