Skip to content

vibecode nice checks to see if we need to create the openconext user #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrvanes merged 2 commits into from
Jul 10, 2025
Merged

vibecode nice checks to see if we need to create the openconext user #47

mrvanes merged 2 commits into from
Jul 10, 2025

Conversation

@baszoetekouw
Copy link
Member

@baszoetekouw baszoetekouw commented Jul 9, 2025

No description provided.

@baszoetekouw baszoetekouw requested a review from mrvanes July 9, 2025 19:39
@baszoetekouw baszoetekouw self-assigned this Jul 9, 2025
@mrvanes
Copy link
Contributor

mrvanes commented Jul 10, 2025 

# docker run --name python3 --env RUNAS_UID=10001 --env RUNAS_GID=10001 python3:mve
Remove old container
python3

Run with env
Creating group 'openconext' with GID 10001
Creating user 'openconext' with UID 10001 and GID 10001
Dropping privileges to 10001:10001
Running custom scripts in /container-init as root
Running custom scripts in /container-init-post

Start container
Group 'openconext' already exists with correct GID 10001
User 'openconext' already exists with correct UID 10001
Dropping privileges to 10001:10001
Running custom scripts in /container-init as root
Running custom scripts in /container-init-post


# docker run --name python3 python3:mve
Remove old container
python3

Run without env
Creating group 'openconext' with GID 10000
Creating user 'openconext' with UID 10000 and GID 10000
Dropping privileges to 10000:10000
Running custom scripts in /container-init as root
Running custom scripts in /container-init-post

Start container
Group 'openconext' already exists with correct GID 10000
User 'openconext' already exists with correct UID 10000
Dropping privileges to 10000:10000
Running custom scripts in /container-init as root
Running custom scripts in /container-init-post

@crosmuller
Copy link
Contributor

crosmuller commented Jul 10, 2025

ziet er goed uit

@mrvanes mrvanes merged commit 547093d into main Jul 10, 2025
1 check passed
baszoetekouw
baszoetekouw commented Jul 10, 2025
View reviewed changes
python3/bin/entrypoint.sh
echo "Dropping privileges to $($PRIVDROP id -u):$($PRIVDROP id -g)"
fi
PRIVDROP=$(create_user_and_group "${RUNAS_UID:-$DEFAULT_UID}" "${RUNAS_GID:-$DEFAULT_GID}")
echo "Dropping privileges to $($PRIVDROP id -u):$($PRIVDROP id -g)"
Copy link
Member Author

@baszoetekouw baszoetekouw Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik denk dat dit containers breekt die geen RUNAS gebruiken, zoals bv Stats

Copy link
Member Author

@baszoetekouw baszoetekouw Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misschien vooral een reden om dei containers dan ook aan te passen wellicht. Maar dan nog heb ik denk ik een harde error dan impliciet default gedrag dat dingen kapot maakt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrvanes mrvanes Awaiting requested review from mrvanes

Assignees

@baszoetekouw baszoetekouw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@baszoetekouw @mrvanes @crosmuller