Open
Conversation
snyaggarwal
approved these changes
Sep 23, 2021
snyaggarwal
reviewed
Sep 23, 2021
| locked_date: 'date', | ||
| experimental: 'boolean' | ||
| } | ||
| const DEFAULT_VISIBLE_ATTRIBUTES = [ |
Contributor
There was a problem hiding this comment.
shouldn't this come from DEFAULT_CONFIG? why redefine here?
| } | ||
| ) | ||
| } | ||
| const getHiddenAttributes = () => { |
Contributor
There was a problem hiding this comment.
for single line methods you dont need {} and return:
const getHiddenAttribute = () => ({...get(config, 'config.header.invisibleAttributes'), ...getDefaultHiddenAttributes()})
| setLogoURL(get(response, 'data.logo_url', logoURL)) | ||
| }) | ||
| } | ||
| const getDefaultHiddenAttributes = () => { |
Contributor
There was a problem hiding this comment.
for single line methods you dont need {} and return:
| }) | ||
| } | ||
| const getDefaultHiddenAttributes = () => { | ||
| return filter(DEFAULT_VISIBLE_ATTRIBUTES, (attr) => { |
Contributor
There was a problem hiding this comment.
for single argument you dont ().
| <HeaderAttribute label="Collection Type" value={collection.collection_type} gridClass="col-md-12" /> | ||
| <HeaderAttribute label="Supported Locales" value={<SupportedLocales {...collection} />} gridClass="col-md-12" type="component" /> | ||
| <HeaderAttribute label="Custom Validation Schema" value={collection.custom_validation_schema} gridClass="col-md-12" /> | ||
| {map(get(config, 'config.header.visibleAttributes'), (attr) => { |
Contributor
There was a problem hiding this comment.
for single argument you dont ().
| </div> | ||
| } | ||
| <HeaderAttribute label="Company" value={org.company} gridClass="col-md-12" /> | ||
| {map(get(config, 'config.header.attributes'), (attr) => { |
Contributor
There was a problem hiding this comment.
for single argument you dont ().
| compositional: 'boolean', | ||
| version_needed: 'boolean', | ||
| } | ||
| const DEFAULT_VISIBLE_ATTRIBUTES = [ |
Contributor
There was a problem hiding this comment.
Pick this from DEFAULT_CONFIG.
May be extract out defaultConfig.js for all orgs/sources/collections respectively and import.
snyaggarwal
reviewed
Sep 23, 2021
src/components/orgs/OrgHome.jsx
Outdated
| { | ||
| label: "Company", | ||
| value: "company", | ||
| type:"text" |
src/components/orgs/OrgHome.jsx
Outdated
| { | ||
| label: "Location", | ||
| value: "location", | ||
| type:"text" |
src/components/orgs/OrgHome.jsx
Outdated
| { | ||
| label: "Website", | ||
| value: "website", | ||
| type:"url" |
snyaggarwal
approved these changes
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Header customization added in Source, Org and Collection headers