Feature/lx200 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated CMakeLists.txt to rename project to lx200_lib_test and include additional test source files. - Added README.md to document the LX200 Library Test Suite, including test structure, categories, running instructions, and known limitations. - Enhanced prj.conf to enable logging, assertions, and increased stack size for complex tests. - Expanded main.c with comprehensive test cases for parser initialization, command parsing, and error handling. - Created test_coordinates.c to outline specifications for unimplemented coordinate parsing functions, including RA, Dec, Alt/Az, and time/date parsing. - Updated testcase.yaml to include relevant tags and platform allowances for the LX200 tests.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a full test suite for the LX200 protocol parser and integrates the LX200 library into the Zephyr build system.
- Introduces comprehensive Zephyr ztests for parsing, formatting, and validation (currently stubbed) of LX200 commands and coordinates
- Updates build and configuration (CMakeLists, Kconfig, prj.conf) to include the LX200 library and enable logging/assertions
- Adds test metadata, documentation (README.md), and YAML config to run the tests on supported platforms
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/lib/lx200/testcase.yaml | Fix test metadata: tags, timeout, and allowed platforms |
| tests/lib/lx200/src/test_coordinates.c | Add specification tests for all coordinate parsing functions |
| tests/lib/lx200/src/main.c | Expand ztest suites covering parser, utils, and error cases |
| tests/lib/lx200/prj.conf | Enable logging, assertions, and increase stack size |
| tests/lib/lx200/README.md | Document test structure, categories, and run instructions |
| tests/lib/lx200/CMakeLists.txt | Include new test sources and rename the test project |
| lib/lx200/lx200.c | Implement core parser logic; stubs for unimplemented features |
| lib/lx200/Kconfig | Integrate LX200 logging config |
| lib/lx200/CMakeLists.txt | Hook lx200.c into the Zephyr library build |
| lib/CMakeLists.txt | Add lx200 subdirectory under lib/ |
| include/lx200/lx200.h | Update documentation (command families, parameter docs) |
| app/prj.conf | Enable LX200 support in the application |
| .github/copilot-instructions.md | Add AI assistant instructions for the repo |
| .clang-format | Introduce project-wide formatting rules |
Comments suppressed due to low confidence (1)
tests/lib/lx200/testcase.yaml:2
- The
commonsection mixes a sequence item (- tags: extensibility) and a mapping key (tags:) at the same level, resulting in invalid YAML. Consolidate into a single mapping undercommon(e.g., remove the sequence item and definetags:as a list) so the file parses correctly.
tags:
|
|
||
| LOG_INF("Successfully parsed LX200 command: '%s'%s%s", command->command, | ||
| command->has_parameter ? " with parameter: '" : "", | ||
| command->has_parameter ? command->parameter : ""); |
There was a problem hiding this comment.
[nitpick] The log message adds the opening apostrophe for parameters but doesn't include a closing apostrophe. Consider updating the format string to " with parameter: '%s'" so the log reads correctly.
Suggested change
| command->has_parameter ? command->parameter : ""); | |
| command->has_parameter ? command->parameter : "'"); |
…ions and README with setup, configuration, and build details
…st in LX200 tests - The LX200 test configuration had robin_nano in integration_platforms but not in platform_allow - This caused Twister to error when trying to run integration tests on robin_nano platform - Added robin_nano to platform_allow list to resolve the build failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.