fix: add oa-atomacos dependency for macOS window capture#16
Merged
Conversation
oa-atomacos is imported in window/_macos.py but was missing from pyproject.toml, causing ImportError on macOS. The package (OpenAdapt's fork of atomacos) fixes pickle serialization of namedtuples needed for window state capture. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
abrichr
force-pushed
the
fix/oa-atomacos-dependency
branch
from
bf99d05 to
6be401a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oa-atomacos>=3.2.0; sys_platform == 'darwin'topyproject.tomldependenciesoa_atomacosis already imported inwindow/_macos.pybut was missing from the dependency list, causingImportErroron macOSoa-atomacosis OpenAdapt's fork ofatomacosthat fixes pickle serialization of namedtuples (needed for window state capture)Test plan
uv syncinstalls oa-atomacos on macOSuv run pytest tests/ -v --ignore=tests/test_browser_bridge.py— 147 passedfrom openadapt_capture.window._macos import get_active_window_statereturns valid window info🤖 Generated with Claude Code