[BUG][DART] fix Optional<T> fromJson wrapping#23811
Open
timonrieger wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 15 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
Author
|
cc @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08) |
Member
|
thanks for the PR can you please review the build failure when you've time? https://github.com/OpenAPITools/openapi-generator/actions/runs/26029167650/job/76510300895?pr=23811 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
useOptional=true(added in #22257) is enabled, thex-is-optionalvendor extension correctly wraps scalar fields inOptional.present()/Optional.absent()duringfromJsondeserialization. However, six collection branches and the numeric branch innative_class.mustacheare missing this check entirely, causing generatedfromJsonmethods to return rawList<T>,Map<K,V>, or call the non-existentOptional<num?>.parse()constructor whereOptional<T>is expected.This produces compile errors in any Dart project using
useOptional=truewith optional array, map, or numeric fields.Scalar fields (non-collection, non-numeric) already had correct
x-is-optionalhandling at lines 290–304 of the template. This PR extends the same pattern to the remaining branches.Relation to #23365
This PR conflicts with #23365 on two lines inside the
{{^vendorExtensions.x-is-optional}}branch of the nested-array hunk (thelistFromJson(json[r'...'])and.cast<T>()fixes). #23365 should be merged first, then those two conflict lines become a no-op resolution. Thus I stacked this PR on top of #23365. The two PRs are otherwise independent and fix non-overlapping issues.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)