Skip to content

Correctly set the Java version in the README for Vert.x 5 project#23698

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
sjw2547:master
May 6, 2026
Merged

Correctly set the Java version in the README for Vert.x 5 project#23698
wing328 merged 2 commits intoOpenAPITools:masterfrom
sjw2547:master

Conversation

@sjw2547
Copy link
Copy Markdown
Contributor

@sjw2547 sjw2547 commented May 5, 2026

…ects

Fixes #23697 - Set the Java version based on the Vert.x 5 flag

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes #23697. Update Vert.x Java client READMEs to show the correct Java requirement: Vert.x 5 requires Java 11+ (Vert.x 3/4 remain Java 8+).

  • Bug Fixes
    • Added Vert.x README template that sets the Java version based on the Vert.x 5 flag.
    • Updated samples/client/petstore/java/vertx5 and samples/client/petstore/java/vertx5-supportVertxFuture READMEs to Java 11+.

Written for commit c515aa0. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 76 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
On a pro plan you can use ultrareview for larger PRs.

@wing328 wing328 merged commit 075fada into OpenAPITools:master May 6, 2026
85 checks passed
@wing328 wing328 added this to the 7.23.0 milestone May 6, 2026
@wing328 wing328 changed the title #23697 Correctly set the Java version in the README for Vert.x 5 proj… Correctly set the Java version in the README for Vert.x 5 project May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect Java version requirement in README for Vert.x 5

2 participants