Skip to content

Enhance pageable validation by adding minSize and minPage constraints Search also allOf references for constraints and defaults#23694

Draft
Picazsoo wants to merge 5 commits intoOpenAPITools:masterfrom
Picazsoo:bugfix/pageable-scan-resolve-allof-constraints
Draft

Enhance pageable validation by adding minSize and minPage constraints Search also allOf references for constraints and defaults#23694
Picazsoo wants to merge 5 commits intoOpenAPITools:masterfrom
Picazsoo:bugfix/pageable-scan-resolve-allof-constraints

Conversation

@Picazsoo
Copy link
Copy Markdown
Contributor

@Picazsoo Picazsoo commented May 5, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Adds minSize and minPage support to pageable validation and fixes constraint/default resolution through allOf/$ref. Generated Spring and Kotlin endpoints now apply correct bounds and defaults via @ValidPageable and @PageableDefault.

  • New Features

    • @ValidPageable now supports minSize and minPage in both Java and Kotlin templates.
    • Spring and Kotlin generators emit these attributes when present.
  • Bug Fixes

    • Pageable scanning resolves maximum, minimum, and default values through $ref and allOf, using intersection semantics (smallest max/largest min; inline default wins).
    • Constraints and defaults on shared component schemas are detected and applied, including generating @PageableDefault from allOf references.
    • Improved array detection in sort enum scanning to avoid missing enums on array schemas.

Written for commit 0701d5b. Summary will update on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant