Skip to content

fix(java): preserve user templateDir for feign-hc5 library#23231

Open
BartPraats wants to merge 1 commit intoOpenAPITools:masterfrom
BartPraats:fix/feign-hc5-template-dir
Open

fix(java): preserve user templateDir for feign-hc5 library#23231
BartPraats wants to merge 1 commit intoOpenAPITools:masterfrom
BartPraats:fix/feign-hc5-template-dir

Conversation

@BartPraats
Copy link

@BartPraats BartPraats commented Mar 13, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

fixes #23139
@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg
Can one of you take a look pls?


Summary by cubic

Keep the user’s templateDir for Java feign-hc5 clients; only fall back to built-in feign templates when no custom dir is set. Fixes #23139.

  • Bug Fixes
    • Guarded setTemplateDir(FEIGN) in JavaClientCodegen.processOpts with a CodegenConstants.TEMPLATE_DIR check.
    • Added tests to confirm defaulting to feign and preserving a custom templateDir.

Written for commit efc4b45. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files


Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
  • Ask questions if you need clarification on any suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][Java][feign-hc5] templateResourcePath / templateDir is overwritten by feign-hc5 library in processOpts()

1 participant