Skip to content

Conversation

@jpfinne
Copy link
Contributor

@jpfinne jpfinne commented Jan 26, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Adds Jackson annotations to generated Spring model constructors so Jackson can use property-based deserialization. Applies to all-args or required-args constructors when Jackson is enabled, and skips XML.

  • New Features
    • Add @JsonCreator(mode = PROPERTIES) to all-args constructors when x-java-all-args-constructor is used.
    • Add @JsonCreator and @JsonProperty to required-args constructors when all fields are required and no all-args constructor exists.
    • Annotate constructor parameters with @JsonProperty for correct field names, including nullable and container types.
    • Update pojo.mustache, SpringCodegen, tests, and regenerate samples; no annotations added when withXml is true.

Written for commit 82d6263. Summary will update on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant