[JAVA] Address [rawtypes] and [this-escape] warnings in generated API clients#20466
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Jan 18, 2025
Merged
Conversation
Member
|
thanks for the PR cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) |
wing328
reviewed
Jan 18, 2025
| } | ||
|
|
||
| protected String getDefaultBaseUri() { | ||
| private String getDefaultBaseUri() { |
Member
There was a problem hiding this comment.
generally i'm ok with the PR but if later users have a use case that need protected method here for example, we will need to provide a way to fallback.
5 tasks
5 tasks
timon-sbr
pushed a commit
to timon-sbr/openapi-generator
that referenced
this pull request
Mar 13, 2025
… clients (OpenAPITools#20466) * Address [rawtypes] and [this-escape] warnings in generated API clients * Commit updated sample files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work resolves the following issue - #18384
Integration tests have been executed manually according to the contribution guidelines.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)