Skip to content

Potential fixes for 2 code quality findings#211

Closed
Jordonbc wants to merge 2 commits intoDevfrom
ai-findings-autofix/Justfile
Closed

Potential fixes for 2 code quality findings#211
Jordonbc wants to merge 2 commits intoDevfrom
ai-findings-autofix/Justfile

Conversation

@Jordonbc
Copy link
Copy Markdown
Collaborator

@Jordonbc Jordonbc commented Apr 5, 2026

This PR applies 2/2 suggestions from code quality AI findings.

Jordonbc and others added 2 commits April 5, 2026 12:12
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

Review Summary

The changes remove || true from test and fix commands, which is a positive change.

Quality Issues Fixed:

  • Commands now properly propagate failures instead of silently passing
  • CI/CD pipelines and developers will see actual test/type-check failures

No Bugs Introduced:

  • This is purely behavioral cleanup, not functional code changes

Minor Suggestion:

The test recipe could potentially run all three commands even if one fails (using ; instead of &&), but the current approach is arguably better since it fails fast. If you want to see all failures regardless, you could change it to:

test:
  cd Frontend && npm exec tsc -- -p tsconfig.json --noEmit; \
  cd Frontend && npx vitest run; \
  cargo test --workspace

Otherwise, LGTM - the changes correctly address the code quality findings about masking failures.

New%20session%20-%202026-04-05T11%3A12%3A45.147Z
opencode session  |  github run

@Jordonbc
Copy link
Copy Markdown
Collaborator Author

Jordonbc commented Apr 5, 2026

/oc can you fix the minor issue?

@opencode-agent
Copy link
Copy Markdown

opencode-agent bot commented Apr 5, 2026

The PR has already removed the || true from both test and fix commands. The current Justfile looks correct.

Are you referring to the optional suggestion in the review about running all three test commands even if one fails (using ; instead of the current fail-fast approach)? Or is there a different minor issue you'd like addressed?

New%20session%20-%202026-04-05T11%3A16%3A05.822Z
opencode session  |  github run

@Jordonbc Jordonbc closed this Apr 5, 2026
@Jordonbc Jordonbc deleted the ai-findings-autofix/Justfile branch April 5, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant