Skip to content

Enhance README with Docker instructions#14

Closed
berezovskyi wants to merge 1 commit intoOpen-MBEE:developfrom
berezovskyi:patch-1
Closed

Enhance README with Docker instructions#14
berezovskyi wants to merge 1 commit intoOpen-MBEE:developfrom
berezovskyi:patch-1

Conversation

@berezovskyi
Copy link
Copy Markdown

Added Docker Compose instructions for running services. Other changes:

  • align manual Docker run port with the one used by Docker Compose
  • bind to a loopback IP address to avoid unintentionally exposing services externally on the WAN

Added Docker Compose instructions for running services and updated run command for SysML v2 server.
Copilot AI review requested due to automatic review settings January 6, 2026 19:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the README documentation by adding Docker Compose instructions for running the SysML v2 microservice along with its prerequisite services. The changes improve the developer experience by providing multiple deployment options and aligning port configurations.

  • Added Docker Compose instructions as the primary method for running the full service stack
  • Updated manual Docker run command to use port 8083 (matching Docker Compose) and bind to loopback address for improved security
  • Added clarifying text to differentiate between running the full stack vs. a single container

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment on lines +24 to +31
docker compose -f .\docker-compose\docker-compose.yml up
```

To run a single container for the SysML v2 server (other components need to be started separately):

```
docker build -t org.openmbee.flexo.sysmlv2 .
docker run -p 8080:8080 org.openmbee.flexo.sysmlv2
docker run -p 127.0.0.1:8083:8080 org.openmbee.flexo.sysmlv2
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation states that binding to a loopback IP address is to avoid unintentionally exposing services externally, but this instruction only applies to the manual Docker run command. The Docker Compose file at docker-compose/docker-compose.yml uses "8083:8080" without loopback binding, which would expose the service externally. For consistency with the security goal, consider documenting this difference or ensuring both methods follow the same security practice.

Copilot uses AI. Check for mistakes.
Comment thread README.md
Via Docker Compose that starts the prerequisite services:

```
docker compose -f .\docker-compose\docker-compose.yml up
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path uses backslashes which are Windows-specific. For better cross-platform compatibility, use forward slashes instead. Docker Compose accepts forward slashes on all platforms including Windows.

Suggested change
docker compose -f .\docker-compose\docker-compose.yml up
docker compose -f ./docker-compose/docker-compose.yml up

Copilot uses AI. Check for mistakes.
@dlamoris
Copy link
Copy Markdown
Contributor

dlamoris commented Mar 3, 2026

added changes to develop

@dlamoris dlamoris closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants