Open
Conversation
soxofaan
reviewed
May 8, 2026
| raise NotImplementedError | ||
|
|
||
| def evaluate(self, process_graph: dict, env: EvalEnv = None): | ||
| def evaluate(self, process_graph: dict, env: EvalEnv = None, do_dry_run: Union[bool, DryRunDataTracer] = True): |
Member
There was a problem hiding this comment.
Hmm, not a big fan of this change: this makes the dry-run aspect leak into the generic Processing.evaluate() API, which is not intended to be concerned with dry and wet run aspects.
For example: this will break the aggregator, which also implements this API, but has no dry-run concept
Member
There was a problem hiding this comment.
Isn't it possible to pass the tracer trough the existing EvalEnv instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open-EO/openeo-geopyspark-driver#1436