fix: improve Slack support and fix Windows community plugin installer…#259
Closed
adambeazley wants to merge 1 commit into
Closed
fix: improve Slack support and fix Windows community plugin installer…#259adambeazley wants to merge 1 commit into
adambeazley wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… crash
Summary
This PR improves support for the Slack adapter on Windows and makes community channel adapters more reliable when installed manually.
Related Issues
openacp installcommand was crashing on Windows with a libuv assertion error (UV_HANDLE_CLOSING).Type of Change
Changes Made
Replaced fragile
execFileusage with a more robustspawn-based npm install in the plugin installer (fixes the Windows crash).Added proper first-class Slack support (
CHANNEL_META, status reporting, and configuration flow).Improved handling for manually installed channel adapters so they get better recognized during boot.
Testing
pnpm test— all tests passPlatform Impact
Screenshots / Recordings
Checklist
.jsextensions)pnpm buildsuccessfullysrc/cli/plugin-template/