refactor(demo): [SDK-4217] remove stop-updating button and deprecate exit API#1935
Merged
fadi-george merged 3 commits intomainfrom Apr 2, 2026
Merged
refactor(demo): [SDK-4217] remove stop-updating button and deprecate exit API#1935fadi-george merged 3 commits intomainfrom
fadi-george merged 3 commits intomainfrom
Conversation
nan-li
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Remove the "Stop Updating Live Activity" button from the demo app and deprecate
LiveActivities.exit()in the SDK public API.Details
Motivation
The
exit/exitLiveActivitymethod unsubscribes a device from future updates for a given activity ID, but ending a Live Activity via the REST API (which the demo already supports) is the recommended approach. Removing the button simplifies the demo UI and aligns with the updated shared build spec.Scope
LiveActivitySection→HomeScreen→AppContext→OneSignalRepository)@deprecatedJSDoc annotations toexitLiveActivityinNativeOneSignal.tsandLiveActivities.exit()inindex.tsdestructivevariant (onlyprimaryandoutlinedremain)Testing
Unit testing
All 244 existing tests pass via
vp test. No test changes needed —exittests remain to cover the deprecated-but-still-functional API.Manual testing
LiveActivities.exit()still works but shows as deprecated in IDEAffected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor