Skip to content

chore: remove unused workflows and stale CI config#1662

Merged
nan-li merged 3 commits into
mainfrom
chore/remove_unused_scripts
May 15, 2026
Merged

chore: remove unused workflows and stale CI config#1662
nan-li merged 3 commits into
mainfrom
chore/remove_unused_scripts

Conversation

@nan-li
Copy link
Copy Markdown
Contributor

@nan-li nan-li commented May 14, 2026

Description

One Line Summary

Removes unused Asana sync, Claude, and issue response-time workflows along with stale Travis config and superseded root files.

Details

Motivation

  • We no longer use Asana, so removing them eliminates the vulnerability rather than patching it.
  • The Claude workflows (claude.yml, claude-code-review.yml) are redundant — Claude code review and @claude mentions are provisioned separately by the platform team, so the per-repo YAMLs do nothing useful.
  • set_response_time.yml plus its two .js helpers (os_probot_metadata.js, set_response_times.js) stamp a response_time_in_business_days value into hidden probot metadata on each issue. Nothing reads the metric.
  • .travis.yml pins Xcode 11.1 / iPhone 8 Plus / iOS 13.1 (2019); active CI is .github/workflows/ci.yml on Xcode 16.4.
  • issue_template.md at the repo root is shadowed by .github/ISSUE_TEMPLATE/*.yml form templates.
  • default is overwritten by ci.yml on every run, so the committed copy isn't load-bearing.

nan-li added 3 commits May 14, 2026 15:25
The workflow stamped response_time_in_business_days into a hidden
probot metadata block on each issue. No consumer reads the value.
- .travis.yml: pins Xcode 11.1 / iOS 13.1 from 2019; CI runs on
  .github/workflows/ci.yml (Xcode 16.4).
- issue_template.md: shadowed by .github/ISSUE_TEMPLATE/*.yml form
  templates, which GitHub prefers.
- default: ci.yml writes this file every run, so the committed copy
  is not load-bearing.
@nan-li nan-li changed the title chore: [SDK-4532] remove unused workflows and stale CI config chore: remove unused workflows and stale CI config May 14, 2026
@nan-li nan-li requested a review from a team May 14, 2026 22:39
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward deletion of unused workflows, stale Travis config, and superseded root files.

Extended reasoning...

Overview

This PR is deletion-only, removing 11 files: three Asana sync workflows, two Claude Code workflows, the response-time tracking workflow plus its two JS helpers (os_probot_metadata.js, set_response_times.js), the stale .travis.yml, the root issue_template.md, and the default scheme file. No SDK or production code is touched.

Security risks

None — this PR reduces attack surface. Removing the Asana workflows eliminates the third-party PAT dependency and any associated supply-chain risk. The Claude workflows that used ANTHROPIC_API_KEY are also removed (they're provisioned separately by the platform team per the description). No new secrets, permissions, or auth flows are introduced.

Level of scrutiny

Low. This is mechanical cleanup of CI/repo infrastructure with clearly-documented motivation for each file. I verified via grep that no remaining file in the repo references any of the deleted paths, and confirmed ci.yml (lines 23-25) regenerates the default file on each run, so the committed copy is indeed non-load-bearing. The .github/ISSUE_TEMPLATE/ directory contains three form templates that shadow the deleted root issue_template.md.

Other factors

Recent commit history (85d7103, c76f860, 962fd8a) shows the deletions split into logical commits, each matching one cluster of removals described in the PR. No bugs were flagged by the bug hunting system. The PR is small, self-contained, and trivially reversible via git revert if any deletion turns out to be load-bearing.

@nan-li nan-li merged commit fca0943 into main May 15, 2026
3 of 4 checks passed
@nan-li nan-li deleted the chore/remove_unused_scripts branch May 15, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants