Skip to content

Conversation

@nan-li
Copy link
Contributor

@nan-li nan-li commented Dec 12, 2025

Description

One Line Summary

Remove unused weak hash algorithms (MD5/SHA1), as it is dead code and a false security liability.

Details

Motivation

Scope

Remove dead code

Testing

Unit testing

None

Manual testing

Run example app on emulator 18.5

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

- Removes unused hashUsingSha1() and hashUsingMD5() methods and associated CommonCrypto declarations. These were legacy methods that are no longer used.
- Fixes #1546
@nan-li nan-li requested a review from a team December 12, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants