Skip to content

Conversation

@onesignal-deploy
Copy link
Collaborator

@onesignal-deploy onesignal-deploy commented Jan 28, 2026

Channels: Current

🛠️ Native Dependency Updates

  • Update Android SDK from 5.4.2 to 5.6.0
    • feat: 🎉 introduces Custom Events Support for the Android SDK. To get started with using Custom Events, please contact support@onesignal.com to enable this feature for your app. Please see documentation on Custom Events.
    • feat: IAMs now display when triggers added before first fetch (#2528)
    • fix: end initialization early if device storage is locked (#2520)

    • feature: Exposing accessors thru suspend (#2502)
    • fix: a rare NPE from PermissionViewModel introduced in 5.4.0 (#2504)
    • fix: NPE in SyncJobService since 5.4 (#2500)
    • fix: Rare User and Subscription creates and updates processing out of order (introduced in 5.4.0) (#2419)
    • fix: Remove throwing "initWithContext was not called or timed out", introduced in 5.4.0 (#2408)
    • Improvement: failure message shows that appID is missing (#2506)
    • improvement: Offloaded work on background threads. (#2394)

  • Update iOS SDK from 5.2.16 to 5.4.0
    • feat: IAMs now display when triggers added before first fetch (OneSignal-iOS-SDK#1635)
    • fix: use locale-independent formatting for purchase prices (OneSignal-iOS-SDK#1634)
    • It is recommended to test this beta version with a new iOS-only app, as Identity Verification is not yet supported on the OneSignal Android and Web SDKs.
    • Enabling Identity Verification in the dashboard will affect all existing app installations using the OneSignal user model SDKs.
    • Please test thoroughly prior to production use, and reach out with any questions, feedback, or concerns.
    • While emails and sms numbers can be added using the SDK, removing them is not yet supported.
    • Live Activities is not yet supported.
    • Rebased to 5.2.14 for more bug fixes and stability improvement.
    • add public log listener methods (see PR for usage) #1576
    • It is recommended to test this beta version with a new iOS-only app, as Identity Verification is not yet supported on the OneSignal Android and Web SDKs.
    • Enabling Identity Verification in the dashboard will affect all existing app installations using the OneSignal user model SDKs.
    • Please test thoroughly prior to production use, and reach out with any questions, feedback, or concerns.
    • While emails and sms numbers can be added using the SDK, removing them is not yet supported.
    • Live Activities is not yet supported.

This change is Reviewable

@claude
Copy link

claude bot commented Jan 29, 2026

Code Review - Version Header Issue Found

I found one issue during the code review:

Issue: Incorrect Version Header Encoding

Files affected:

  • com.onesignal.unity.core/Runtime/OneSignalPlatform.cs (line 43)
  • com.onesignal.unity.ios/Runtime/Plugins/iOS/UIApplication+OneSignalUnity.mm (line 100)

Problem:
The version header is incorrectly set to "000520" for version 5.2.0. According to the documented encoding scheme in composeRelease.sh (lines 169-180), each version component (major, minor, patch) should be zero-padded to 2 digits.

For version 5.2.0, this should be:

  • Major: 05
  • Minor: 02
  • Patch: 00
  • Result: "050200"

The current value "000520" would be interpreted as version 0.5.20 or 0.0.520.

Root cause:
The GitHub Actions workflow at .github/workflows/create-release-pr.yml line 128 uses an incorrect algorithm that strips dots before padding (5.2.0 to 520 to 000520), rather than padding each component separately (5.2.0 to 05.02.00 to 050200).

Suggested fixes:

In com.onesignal.unity.core/Runtime/OneSignalPlatform.cs line 43:
Change: public const string VersionHeader = "000520";
To: public const string VersionHeader = "050200";

In com.onesignal.unity.ios/Runtime/Plugins/iOS/UIApplication+OneSignalUnity.mm line 100:
Change: [OneSignalWrapper setSdkVersion:@"000520"];
To: [OneSignalWrapper setSdkVersion:@"050200"];

Also fix the workflow file to use the correct encoding logic from composeRelease.sh.

Note: The previous version 5.1.16 was also incorrectly encoded as "005116" instead of "050116", indicating this bug has existed in prior releases as well.

@fadi-george fadi-george deleted the rel/5.2.0 branch January 30, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants