chore: Release 5.5.5#1145
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — straightforward release: version bump to 5.5.5 and Android native SDK bump to 5.9.0.
Extended reasoning...
Overview
This is a release PR that bumps the Flutter SDK version from 5.5.4 to 5.5.5 across pubspec.yaml, android/build.gradle, and ios/onesignal_flutter.podspec, updates the SDK version string from "050504" to "050505" in both OneSignalPlugin.java and OneSignalPlugin.m, and bumps the Android native dependency com.onesignal:OneSignal from 5.8.1 to 5.9.0. The iOS OneSignalXCFramework pin remains at 5.5.1 (unchanged).
Security risks
None introduced by this PR. The Android SDK 5.9.0 release notes referenced in the description include defensive JSON parsing fixes (SDK-4478, SDK-4494) and an init race fix (SDK-4475), which are improvements over 5.8.1. Identity Verification is a new feature in the upstream SDK but is not surfaced through any new bridge code in this PR.
Level of scrutiny
Low. This is a mechanical version-bump release PR matching the exact pattern used in prior releases (e.g. dda93a9 "Release 5.5.5" predecessor, b4c2ea5 "Update Android SDK to 5.9.0"). All five touched files contain only string/version changes — no new logic, no API surface changes on the Flutter side. The native SDK bump is the substantive change, but its risk is owned by the OneSignal-Android-SDK repo's own review process.
Other factors
The version strings are kept in sync as required by the in-source comment ("Keep in sync with pubspec.yaml version"). All five locations were updated consistently. No outstanding reviewer comments or unresolved discussion in the timeline.
The unquoted glob in `cp build/ios/ipa/*.ipa Runner.ipa` word-splits when Flutter produces an IPA whose filename contains a space (e.g. "OneSignal Demo.ipa"), causing `cp` to expect the destination to be a directory and fail with `cp: build/ios/ipa/Runner.ipa is not a directory`. Co-authored-by: Cursor <cursoragent@cursor.com>
When Flutter produces `build/ios/ipa/Runner.ipa` directly, the previous `for f in *.ipa; cp "$f" Runner.ipa` ran `cp Runner.ipa Runner.ipa` and failed with "are identical (not copied)". Detect the IPA via a nullglob array, error out if none was produced, and only copy when the source and destination differ. Still handles filenames containing spaces. Co-authored-by: Cursor <cursoragent@cursor.com>
fadi-george
force-pushed
the
rel/5.5.5
branch
3 times, most recently
from
e9a407a to
b7190df
Compare
2 participants
Channels: Current
🛠️ Native Dependency Updates
login()is called beforerequestPermission()(#2627)