Skip to content

refactor(controllers): extract nested endpoints into separate classes #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theEvilReaper merged 5 commits into from
Feb 11, 2026
Merged

refactor(controllers): extract nested endpoints into separate classes #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6bb59b6
refactor(font): extract nested endpoints into separate controller cla…
theEvilReaper Feb 10, 2026
f2741c6
refactor(item): extract nested endpoints into separate controller cla…
theEvilReaper Feb 10, 2026
0947623
refactor(sound): extract nested endpoints into separate controller cl…
theEvilReaper Feb 10, 2026
78aa0d4
fix(test): update controller usage
theEvilReaper Feb 10, 2026
f6da989
fix(font): improve some urls in the controller endpoints
theEvilReaper Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
724 changes: 0 additions & 724 deletions src/main/java/net/onelitefeather/vulpes/backend/controller/ItemController.java
View file
Open in desktop

This file was deleted.

170 changes: 170 additions & 0 deletions src/main/java/net/onelitefeather/vulpes/backend/controller/font/FontCharController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,170 @@
package net.onelitefeather.vulpes.backend.controller.font;

import io.micronaut.data.model.Page;
import io.micronaut.data.model.Pageable;
import io.micronaut.http.HttpResponse;
import io.micronaut.http.MediaType;
import io.micronaut.http.annotation.Body;
import io.micronaut.http.annotation.Controller;
import io.micronaut.http.annotation.Delete;
import io.micronaut.http.annotation.Get;
import io.micronaut.http.annotation.PathVariable;
import io.micronaut.http.annotation.Post;
import io.micronaut.http.annotation.Produces;
import io.micronaut.http.annotation.Put;
import io.micronaut.validation.Validated;
import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.media.ArraySchema;
import io.swagger.v3.oas.annotations.media.Content;
import io.swagger.v3.oas.annotations.media.Schema;
import io.swagger.v3.oas.annotations.responses.ApiResponse;
import jakarta.inject.Inject;
import net.onelitefeather.vulpes.backend.domain.font.FontModelResponseDTO;
import net.onelitefeather.vulpes.backend.domain.font.FontStringDTO;
import net.onelitefeather.vulpes.backend.domain.font.FontStringResponseDTO;
import net.onelitefeather.vulpes.backend.service.FontService;
import net.onelitefeather.vulpes.backend.validation.ValidationGroup;

import java.util.List;
import java.util.UUID;

@Controller("/font/chars")
public class FontCharController {

private final FontService fontService;

@Inject
public FontCharController(FontService fontService) {
this.fontService = fontService;
}

@Operation(
summary = "Create character of a font",
operationId = "createChar",
description = "Create the character of a font in the database.",
tags = {"Font"}
)
@ApiResponse(
responseCode = "200",
description = "The characters of the font were successfully created in the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
schema = @Schema(implementation = FontStringResponseDTO.class)
)
)
@Put("/{id}")
@Produces(MediaType.APPLICATION_JSON)
@Validated(groups = ValidationGroup.Create.class)
public HttpResponse<FontStringResponseDTO> createChar(@PathVariable UUID id, @Body FontStringDTO charModel) {
FontStringResponseDTO model = fontService.createCharByFontId(id, charModel);
return HttpResponse.ok(model);
}

@Operation(
summary = "Get characters by font ID",
operationId = "getCharsById",
description = "Gets the characters of a font by its ID from the database.",
tags = {"Font"}
)
@ApiResponse(
responseCode = "200",
description = "The characters of the font were successfully retrieved from the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
schema = @Schema(implementation = FontStringResponseDTO.class)
)
)
@ApiResponse(
responseCode = "404",
description = "The font was not found in the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
schema = @Schema(implementation = FontModelResponseDTO.FontModelErrorDTO.class)
)
)
@Get("/{id}")
@Produces(MediaType.APPLICATION_JSON)
public HttpResponse<Page<FontStringResponseDTO>> readCharsById(@PathVariable UUID id, Pageable pageable) {
Page<FontStringResponseDTO> models = fontService.findCharsByFontId(id, pageable);
return HttpResponse.ok(models);
}

@Operation(
summary = "Update character of a font",
operationId = "updateChar",
description = "Updates the character of a font in the database.",
tags = {"Font"}
)
@ApiResponse(
responseCode = "200",
description = "The characters of the font were successfully updated in the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
array = @ArraySchema(
schema = @Schema(implementation = FontStringResponseDTO.class)
)
)
)
@Post("/{id}")
@Produces(MediaType.APPLICATION_JSON)
@Validated(groups = ValidationGroup.Update.class)
public HttpResponse<FontStringResponseDTO> updateChar(@PathVariable UUID id, @Body FontStringDTO charModel) {
FontStringResponseDTO model = fontService.updateCharByFontId(id, charModel);
return HttpResponse.ok(model);
}

@Operation(
summary = "Delete character of a font",
operationId = "deleteChar",
description = "Delete the character of a font in the database.",
tags = {"Font"}
)
@ApiResponse(
responseCode = "200",
description = "The characters of the font were successfully updated in the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
schema = @Schema(implementation = FontStringResponseDTO.FontStringDTO.class)
)
)
@ApiResponse(
responseCode = "404",
description = "The character was not found in the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
schema = @Schema(implementation = FontStringResponseDTO.FontStringErrorDTO.class)
)
)
@Delete("/{fontId}/{charId}")
@Produces(MediaType.APPLICATION_JSON)
public HttpResponse<FontStringResponseDTO> deleteChar(@PathVariable UUID fontId, @PathVariable UUID charId) {
FontStringResponseDTO model = fontService.deleteCharByFontId(fontId, charId);
if (model instanceof FontStringResponseDTO.FontStringErrorDTO) {
return HttpResponse.notFound(model);
}
return HttpResponse.ok(model);
}

@Operation(
summary = "Delete character of a font",
operationId = "deleteChar",
description = "Delete the character of a font in the database.",
tags = {"Font"}
)
@ApiResponse(
responseCode = "200",
description = "The characters of the font were successfully deleted in the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
array = @ArraySchema(
schema = @Schema(implementation = FontStringResponseDTO.class)
)
)
)
@Delete("/{fontId}/")
@Produces(MediaType.APPLICATION_JSON)
public HttpResponse<List<FontStringResponseDTO>> deleteAllChars(@PathVariable UUID fontId) {
List<FontStringResponseDTO> model = fontService.deleteAllCharByFontId(fontId);
return HttpResponse.ok(model);
}
}
174 changes: 1 addition & 173 deletions ...es/backend/controller/FontController.java → ...ckend/controller/font/FontController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package net.onelitefeather.vulpes.backend.controller;
package net.onelitefeather.vulpes.backend.controller.font;

import io.micronaut.data.model.Page;
import io.micronaut.data.model.Pageable;
Expand All @@ -11,7 +11,6 @@
import io.micronaut.http.annotation.PathVariable;
import io.micronaut.http.annotation.Post;
import io.micronaut.http.annotation.Produces;
import io.micronaut.http.annotation.Put;
import io.micronaut.validation.Validated;
import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.media.ArraySchema;
Expand All @@ -22,8 +21,6 @@
import net.onelitefeather.vulpes.api.model.FontEntity;
import net.onelitefeather.vulpes.backend.domain.font.FontModelDTO;
import net.onelitefeather.vulpes.backend.domain.font.FontModelResponseDTO;
import net.onelitefeather.vulpes.backend.domain.font.FontStringDTO;
import net.onelitefeather.vulpes.backend.domain.font.FontStringResponseDTO;
import net.onelitefeather.vulpes.backend.service.FontService;
import net.onelitefeather.vulpes.backend.validation.ValidationGroup;

Expand Down Expand Up @@ -109,9 +106,6 @@ public HttpResponse<FontModelResponseDTO> getById(@PathVariable UUID id) {
return HttpResponse.notFound(new FontModelErrorDTO("Font not found"));
}




@Operation(
summary = "Remove a font by ID",
operationId = "deleteFont",
Expand Down Expand Up @@ -188,170 +182,4 @@ public HttpResponse<List<FontModelResponseDTO>> deleteAll() {
List<FontModelResponseDTO> result = fontService.deleteAllFonts();
return HttpResponse.ok(result);
}

@Operation(
summary = "Update a font",
operationId = "updateFont",
description = "Updates a font in the database.",
tags = {"Font"}
)
@ApiResponse(
responseCode = "200",
description = "The font was successfully updated in the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
schema = @Schema(implementation = FontModelResponseDTO.FontModelDTO.class)
)
)
@ApiResponse(
responseCode = "404",
description = "The font was not found in the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
schema = @Schema(implementation = FontModelErrorDTO.class)
)
)
@Post("/update")
@Produces(MediaType.APPLICATION_JSON)
@Validated(groups = ValidationGroup.Update.class)
public HttpResponse<FontModelResponseDTO> update(
@Body FontModelDTO model
) {
FontModelResponseDTO result = fontService.updateFont(model);
if (result instanceof FontModelResponseDTO.FontModelErrorDTO) {
return HttpResponse.notFound(result);
}
return HttpResponse.ok(result);
}

@Operation(
summary = "Create character of a font",
operationId = "createChar",
description = "Create the character of a font in the database.",
tags = {"Font"}
)
@ApiResponse(
responseCode = "200",
description = "The characters of the font were successfully created in the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
schema = @Schema(implementation = FontStringResponseDTO.class)
)
)
@Put("/chars/{id}")
@Produces(MediaType.APPLICATION_JSON)
@Validated(groups = ValidationGroup.Create.class)
public HttpResponse<FontStringResponseDTO> createChar(@PathVariable UUID id, @Body FontStringDTO charModel) {
FontStringResponseDTO model = fontService.createCharByFontId(id, charModel);
return HttpResponse.ok(model);
}

@Operation(
summary = "Get characters by font ID",
operationId = "getCharsById",
description = "Gets the characters of a font by its ID from the database.",
tags = {"Font"}
)
@ApiResponse(
responseCode = "200",
description = "The characters of the font were successfully retrieved from the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
schema = @Schema(implementation = FontStringResponseDTO.class)
)
)
@ApiResponse(
responseCode = "404",
description = "The font was not found in the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
schema = @Schema(implementation = FontModelErrorDTO.class)
)
)
@Get("/chars/{id}")
@Produces(MediaType.APPLICATION_JSON)
public HttpResponse<Page<FontStringResponseDTO>> readCharsById(@PathVariable UUID id, Pageable pageable) {
Page<FontStringResponseDTO> models = fontService.findCharsByFontId(id, pageable);
return HttpResponse.ok(models);
}

@Operation(
summary = "Update character of a font",
operationId = "updateChar",
description = "Updates the character of a font in the database.",
tags = {"Font"}
)
@ApiResponse(
responseCode = "200",
description = "The characters of the font were successfully updated in the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
array = @ArraySchema(
schema = @Schema(implementation = FontStringResponseDTO.class)
)
)
)
@Post("/chars/{id}")
@Produces(MediaType.APPLICATION_JSON)
@Validated(groups = ValidationGroup.Update.class)
public HttpResponse<FontStringResponseDTO> updateChar(@PathVariable UUID id, @Body FontStringDTO charModel) {
FontStringResponseDTO model = fontService.updateCharByFontId(id, charModel);
return HttpResponse.ok(model);
}


@Operation(
summary = "Delete character of a font",
operationId = "deleteChar",
description = "Delete the character of a font in the database.",
tags = {"Font"}
)
@ApiResponse(
responseCode = "200",
description = "The characters of the font were successfully updated in the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
schema = @Schema(implementation = FontStringResponseDTO.FontStringDTO.class)
)
)
@ApiResponse(
responseCode = "404",
description = "The character was not found in the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
schema = @Schema(implementation = FontStringResponseDTO.FontStringErrorDTO.class)
)
)
@Delete("/chars/{fontId}/{charId}")
@Produces(MediaType.APPLICATION_JSON)
public HttpResponse<FontStringResponseDTO> deleteChar(@PathVariable UUID fontId, @PathVariable UUID charId) {
FontStringResponseDTO model = fontService.deleteCharByFontId(fontId, charId);
if (model instanceof FontStringResponseDTO.FontStringErrorDTO) {
return HttpResponse.notFound(model);
}
return HttpResponse.ok(model);
}

@Operation(
summary = "Delete character of a font",
operationId = "deleteChar",
description = "Delete the character of a font in the database.",
tags = {"Font"}
)
@ApiResponse(
responseCode = "200",
description = "The characters of the font were successfully deleted in the database.",
content = @Content(
mediaType = MediaType.APPLICATION_JSON,
array = @ArraySchema(
schema = @Schema(implementation = FontStringResponseDTO.class)
)
)
)
@Delete("/chars/{fontId}/")
@Produces(MediaType.APPLICATION_JSON)
public HttpResponse<List<FontStringResponseDTO>> deleteAllChars(@PathVariable UUID fontId) {
List<FontStringResponseDTO> model = fontService.deleteAllCharByFontId(fontId);
return HttpResponse.ok(model);
}
}
Loading
Loading