-
Notifications
You must be signed in to change notification settings - Fork 2
Adds explicit last_login on User
#2276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds explicit last_login on User
#2276
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
TYPE: Bugfix LINK: OGC-2860
TYPE: Bugfix LINK: OGC-2896
13fec7a to
2280603
Compare
Daverball
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
We may be able to do a little bit better with the migration, by pre-populating the new column using any stored session timestamps, if you'd like to try. (users.data['sessions'][...]['timestamp'])
Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.
Commit message
Adds explicit
last_loginon UserTYPE: Feature
LINK: OGC-2454
Checklist