Sayali: restore promote button visibility and persist promoted state after refresh#5239
Sayali: restore promote button visibility and persist promoted state after refresh#5239sayali-2308 wants to merge 2 commits into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
PR-5239.mov
Tested the flow everything is working as expected but I feel below changes are needed
- Both confirmation popups/modals are missing bottom spacing/padding, which makes the UI look cramped.
- In the “Select Multiple Reviewers” flow, the “Promote Selected” action bar appears at the bottom-right corner and overlaps/collides with the up-arrow button in the same position.
- Suggestion: move the action bar to the top-right corner for better visibility and to avoid overlap.
|
|
Hi, resolved the merge conflict and fixed both issues: (1) repositioned the floating 'Promote Selected' bar higher (bottom: 80px) to avoid overlap, and (2) added padding to the confirmation modal footer so Cancel/Confirm buttons don't touch the edge. Please re-review PR #5239. |
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Promote button is visible, confirmation modal opens, promoted state persists after refresh, "Promote Selected" bar appears on multi-select, and dark mode works.
However, the confirmation modal for group promotion is missing bottom padding, making it look tight. This is already fixed for individual promotion but needs to be addressed for group promotion as well.









Description
Fixes reviewer-reported issue where the 🏆 Promote button was not visible on the PR Grading Screen after PR #5152 was merged. Also fixes "Error saving grades" error when using mock data, and adds localStorage persistence so promoted state survives page refresh.
Related PRS (if any):
Follow-up fix for PR #5152
Main changes explained:
…
How to test:
Screenshots or videos of changes:
Note: