Skip to content

Use correct IMAP folder name with imapobj.select#239

Open
derekschrock wants to merge 1 commit intoOfflineIMAP:masterfrom
derekschrock:foldername
Open

Use correct IMAP folder name with imapobj.select#239
derekschrock wants to merge 1 commit intoOfflineIMAP:masterfrom
derekschrock:foldername

Conversation

@derekschrock
Copy link
Copy Markdown
Contributor

Like other imapobj.select translate it vi
imaputil.foldername_to_imapname

This v1.1 template stands in .github/.

This PR

Add character x [x].

  • I've read the DCO.
  • I've read the Coding Guidelines
  • The relevant informations about the changes stands in the commit message, not here in the message of the pull request.
  • Code changes follow the style of the files they change.
  • Code is tested (provide details).

Like other imapobj.select translate it vi
imaputil.foldername_to_imapname
@thekix
Copy link
Copy Markdown
Member

thekix commented Apr 6, 2026

Hi @derekschrock

Thanks for the patch!

I was checking the use of ".select" method. Could be possible to use in these lines or is only for some cases?

➜  offlineimap3 git:(testing) ✗ rgrep select * 2>&1| grep -v ^dist | grep -v ^doc  | grep -v binario | grep -v ^Change | grep -v ^test | grep "\.select" 
offlineimap/folder/IMAP.py:            imapobj.select(self.getfullIMAPname(), force=force)
offlineimap/folder/IMAP.py:            imapobj.select(self.getfullIMAPname(), readonly=True, force=force)
offlineimap/folder/IMAP.py:                restype, imapdata = imapobj.select(self.getfullIMAPname(), True,
offlineimap/folder/IMAP.py:        res_type, imapdata = imapobj.select(a, True, True)
offlineimap/folder/IMAP.py:                    imapobj.select(self.getfullIMAPname())
offlineimap/folder/IMAP.py:                    imapobj.select(self.getfullIMAPname(), readonly=True)
offlineimap/folder/IMAP.py:        imapobj.select(self.getfullIMAPname())
offlineimap/folder/IMAP.py:                imapobj.select(self.getfullIMAPname())
offlineimap/folder/IMAP.py:                imapobj.select(self.getfullIMAPname())
offlineimap/imapserver.py:        # in the third list of select.select() and cause us to return False.
offlineimap/imapserver.py:        _, _, e = select.select([], [], [sock], 0.0)
offlineimap/imapserver.py:                    imapobj.select(self.folder)
offlineimap/repository/IMAP.py:                        imapobj.select(imaputil.utf8_IMAP(imaputil.foldername_to_imapname(foldername)),
offlineimap/imaplibutil.py:            result = super(UsefulIMAPMixIn, self).select(mailbox, readonly)
➜  offlineimap3 git:(testing) ✗ 

Regards,
kix

@derekschrock
Copy link
Copy Markdown
Contributor Author

getfullIMAPname calls foldername_to_imapname

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants