fix: resolve timer leaks and logical errors in Manager and test utilities#4442
Closed
Newt6611 wants to merge 3 commits intoOffchainLabs:masterfrom
Closed
fix: resolve timer leaks and logical errors in Manager and test utilities#4442Newt6611 wants to merge 3 commits intoOffchainLabs:masterfrom
Newt6611 wants to merge 3 commits intoOffchainLabs:masterfrom
Conversation
Move time.After(limit) outside the for loop so the timeout channel is created once rather than being re-created on every iteration, which caused the timeout to never fire and leaked timers.
Replace time.After(time.Second) with ticker.C in tickAtInterval and fastTickWhileCatchingUp to avoid creating a new timer on every loop iteration.
|
|
Contributor
|
Thank you for your contribution. However, this PR has been automatically closed because it was labeled as trivial. As stated in our CONTRIBUTING.md: Important Please, do not send pull requests for trivial changes; these will be rejected.
We appreciate meaningful contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
waitForBlocksToCatchup, movedtime.Afteroutside theforloop. According to the function comment, it is intended to prevent "running this function forever", but the previous implementation reset the timer on every iteration, making the limit ineffective.Manager.go, replacedtime.Afterwith the existingticker.C.tickAtIntervalfollows the intended 12s interval (was 1s).