Use promises in the ExecutionRecorder interface #4186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4186 +/- ##
==========================================
- Coverage 33.41% 33.17% -0.25%
==========================================
Files 461 461
Lines 55901 55910 +9
==========================================
- Hits 18681 18549 -132
- Misses 33921 34115 +194
+ Partials 3299 3246 -53 |
❌ 7 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
bragaigor
reviewed
Dec 30, 2025
Contributor
bragaigor
left a comment
bragaigor
left a comment
There was a problem hiding this comment.
Do we still need to implement ExecutionRecorder methods for ExecutionRPCServer? Something like:
func (c *ExecutionRPCServer) RecordBlockCreation(
ctx context.Context,
pos arbutil.MessageIndex,
msg *arbostypes.MessageWithMetadata,
wasmTargets []rawdb.WasmTarget,
) (*execution.RecordResult, error) {
return c.executionRecorder.RecordBlockCreation(ctx, pos, msg, wasmTargets).Await(ctx)
}and same for PrepareForRecord? But then we would need to add executionRecorder to ExecutionRPCServer or modify ExecutionClient. Or that's be part of another PR? CC: @diegoximenes
Member
Author
|
@bragaigor yes, definitely, but I didn't want to do it in the same PR to keep changes short and granular; this PR is just a part of NIT-4063 (see the description) |
Contributor
|
@pmikolajczyk41 got it, apologies I missread the description. Also prefers smaller increment PRs |
diegoximenes
requested changes
Dec 31, 2025
diegoximenes
previously approved these changes
Jan 6, 2026
execution/gethexec/node.go
Outdated
| ) (*execution.RecordResult, error) { | ||
| return n.Recorder.RecordBlockCreation(ctx, pos, msg, wasmTargets) | ||
| ) containers.PromiseInterface[*execution.RecordResult] { | ||
| return stopwaiter.LaunchPromiseThread(n.ExecEngine, func(ctx context.Context) (*execution.RecordResult, error) { |
Contributor
There was a problem hiding this comment.
Nothing to do about this right now, this is more a question to @tsahee when he reviews this PR 🙂.
Since Promises/LaunchPromiseThread/etc are not a golang native way to handle concurrency, it is not clear to me what would be the ideal scenario here.
It is not clear to me why StopWaiter.LaunchPromiseThread accepts a ThreadLauncher (a StopWaiter "implements" a ThreadLauncher), while StopWaiter.LaunchThread doesn't, for example.
Here ExecutionEngine's StopWaiter is being used to launch a thread in ExecutionNode, and the ctx related to this thread is being used to interact with RecordingDatabase.
Not sure if there is an issue with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
execution.ExecutionRecorderinterface use promise API:ExecutionClientinterfaceTo keep things simple and avoid nesting threads we abandon
BlockRecorderimplementingExecutionRecorderinterface. It is enough that theExecutionNodeimplements it.part of NIT-4063