Skip to content

Conversation

@Tristan-Wilson
Copy link
Member

@Tristan-Wilson Tristan-Wilson commented Dec 30, 2025

fixes: NIT-4234, NIT-4272

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 34.97%. Comparing base (416e512) to head (594bd58).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4182      +/-   ##
==========================================
+ Coverage   33.01%   34.97%   +1.96%     
==========================================
  Files         459      459              
  Lines       55830    55830              
==========================================
+ Hits        18430    19526    +1096     
+ Misses      34185    32842    -1343     
- Partials     3215     3462     +247     

@github-actions
Copy link

github-actions bot commented Dec 30, 2025

❌ 9 Tests Failed:

Tests completed Failed Passed Skipped
4452 9 4443 0
View the top 3 failed tests by shortest run time
TestSetLatestSnapshotUrl
Stack Traces | 0.070s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
    init_test.go:300: running test case latest file with http url
INFO [12-30|12:10:18.216] Set latest snapshot url                  url=http://some.domain.com/arb1/2024/21/archive.tar.gz
    init_test.go:300: running test case latest file with https url
INFO [12-30|12:10:18.217] Set latest snapshot url                  url=https://some.domain.com/arb1/2024/21/archive.tar.gz
    init_test.go:300: running test case chain and contents with upper case
INFO [12-30|12:10:18.219] Set latest snapshot url                  url=http://127.0.0.1:39607/arb1/2024/21/archive.tar.gz
    init_test.go:353: goroutine 99 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x2e5ddd0, 0xc000a00540}, {0x2e30ae0, 0x41b2460}, {0xc000806090, 0x1, 0x1})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/cmd/nitro.Require(0xc000a00540, {0x2e30ae0, 0x41b2460}, {0xc000806090, 0x1, 0x1})
        	/home/runner/work/nitro/nitro/cmd/nitro/config_test.go:304 +0x5d
        github.com/offchainlabs/nitro/cmd/nitro.startFileServer.func2()
        	/home/runner/work/nitro/nitro/cmd/nitro/init_test.go:353 +0xa5
        created by github.com/offchainlabs/nitro/cmd/nitro.startFileServer in goroutine 23
        	/home/runner/work/nitro/nitro/cmd/nitro/init_test.go:350 +0x285
        
    init_test.go:353: �[31;1m [failed to shutdown server] context canceled �[0;0m
--- FAIL: TestSetLatestSnapshotUrl (0.07s)
TestDataStreaming_PositiveScenario/Many_senders,_long_messages
Stack Traces | 0.130s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:230 +0x19b
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 159
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:223 +0x85
        
    protocol_test.go:230: �[31;1m [] too much time has elapsed since request was signed �[0;0m
WARN [12-30|12:11:33.052] Served datastreaming_start               conn=127.0.0.1:45448 reqid=16 duration="106.669µs" err="too much time has elapsed since request was signed"
INFO [12-30|12:11:33.053] rpc response                             method=datastreaming_start logId=16 err="too much time has elapsed since request was signed" result={} attempt=0 args="[\"0x6953c174\", \"0x34\", \"0xd9\", \"0x2b48\", \"0xa\", \"0x8d4c23db822aa1e6ec16112220fd91e35fd50655bd71f76d8140cdc1d773159c61ad687863c4530beb33c9bbf8fef2a77a6abf0607911cdaf340248280de640401\"]" errorData=null
    protocol_test.go:230: goroutine 317 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x161f150, 0xc0006201c0}, {0x16059a0, 0xc000a8a780}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x9f
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:230 +0x19b
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 159
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:223 +0x85
        
    protocol_test.go:230: �[31;1m [] too much time has elapsed since request was signed �[0;0m
--- FAIL: TestDataStreaming_PositiveScenario/Many_senders,_long_messages (0.13s)
TestDataStreaming_PositiveScenario
Stack Traces | 0.170s run time
=== RUN   TestDataStreaming_PositiveScenario
--- FAIL: TestDataStreaming_PositiveScenario (0.17s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee added this pull request to the merge queue Dec 30, 2025
Merged via the queue into master with commit 330bf29 Dec 30, 2025
26 checks passed
@tsahee tsahee deleted the blob-error-decoding-failure branch December 30, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants