[MEL] - Implement recording of preimages related to sequencer batches (DA providers)#4133
[MEL] - Implement recording of preimages related to sequencer batches (DA providers)#4133Tristan-Wilson merged 53 commits intomasterfrom
Conversation
Message extraction function works with logs instead of receipts
| valBatches = append(valBatches, prevBatches...) | ||
|
|
||
| copyPreimagesInto(preimages, fullBatchInfo.Preimages) | ||
| daprovider.CopyPreimagesInto(preimages, fullBatchInfo.Preimages) |
There was a problem hiding this comment.
This doesn't feel like it belongs in daprovider since it's used for all preimages not just DA related ones.
There was a problem hiding this comment.
I added it there because, PreimagesMap type is defined there and this function copies key-value pairs present in that type from source to destination
There was a problem hiding this comment.
It's also used for copying Keccack256 preimages generated from block execution recording recorder.RecordBlockCreation including all trie node reads so I really don't think it belongs just to the daprovider package.
There was a problem hiding this comment.
Then it makes more sense to put in the validator package as ValidationInput is defined there and purpose of this function is to be used in creating a validationInput. I'll move it there and lmk WDYT
|
Marked design-approved, still have one minor comment about the preimage copy function. |
|
Also can you please update https://github.com/OffchainLabs/arbitrum-docs/blob/master/docs/launch-arbitrum-chain/02-configure-your-chain/advanced-configurations/da-api-integration-guide.mdx to describe the new method that DA API integrators must implement. |
PR for this- OffchainLabs/arbitrum-docs#2973 |
4 participants
This PR introduces recording of preimages relating to posted sequencer batches. We introduce a new struct
RecordingDAPReaderSourcethat will cast the underlyingdaprovider.Readers to record preimages. This will be used in recording preimages for MEL validation.Resolves NIT-4194