Skip to content

Conversation

@rauljordan
Copy link
Contributor

@rauljordan rauljordan commented Dec 11, 2025

This PR introduces recorder structs to record preimages for transactions and receipts needed for MEL validation.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
4483 6 4477 0
View the top 3 failed tests by shortest run time
TestVersion40
Stack Traces | 10.700s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [01-09|09:42:09.279] HTTP server stopped                      endpoint=127.0.0.1:41703
TRACE[01-09|09:42:09.280] P2P networking is spinning down
    precompile_inclusion_test.go:94: goroutine 597933 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x412a8b0, 0xc0745db880}, {0x40e76c0, 0xc15d960960}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc0745db880, {0x40e76c0, 0xc15d960960}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:2058 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc0745db880, 0x28, {0xc0c33f1df8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:94 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc0745db880?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc0745db880, 0x3d65ac0)
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (10.70s)
TestStakersCooperative
Stack Traces | 10.790s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
DEBUG[01-09|09:38:40.575] Journaled pathdb diff layer              root=13bd93..8af294 parent=f1dfb4..02ddca id=283                block=282
DEBUG[01-09|09:38:40.575] Journaled pathdb diff layer              root=d379f6..be3abb parent=13bd93..8af294 id=284                block=283
DEBUG[01-09|09:38:40.575] Journaled pathdb diff layer              root=00a436..66c8ca parent=d379f6..be3abb id=285                block=284
DEBUG[01-09|09:38:40.575] Journaled pathdb diff layer              root=4fa491..aa9126 parent=00a436..66c8ca id=286                block=285
DEBUG[01-09|09:38:40.575] Journaled pathdb diff layer              root=055e3b..4f4cad parent=4fa491..aa9126 id=287                block=286
DEBUG[01-09|09:38:40.575] Journaled pathdb diff layer              root=43d4a7..92a73e parent=055e3b..4f4cad id=288                block=287
DEBUG[01-09|09:38:40.575] Journaled pathdb diff layer              root=2135ce..9df962 parent=43d4a7..92a73e id=289                block=288
DEBUG[01-09|09:38:40.575] Journaled pathdb diff layer              root=133c55..f07d1f parent=2135ce..9df962 id=290                block=289
DEBUG[01-09|09:38:40.575] Journaled pathdb diff layer              root=bc8818..523f78 parent=133c55..f07d1f id=291                block=290
INFO [01-09|09:38:40.576] Persisted dirty state to disk            size=806.10KiB elapsed=104.636ms
INFO [01-09|09:38:40.576] Blockchain stopped
TRACE[01-09|09:38:40.576] P2P networking is spinning down
DEBUG[01-09|09:38:40.576] RPC server shutting down
DEBUG[01-09|09:38:40.576] RPC connection read error                err="websocket: close 1006 (abnormal closure): unexpected EOF"
DEBUG[01-09|09:38:40.576] RPC connection read error                err="websocket: close 1006 (abnormal closure): unexpected EOF"
DEBUG[01-09|09:38:40.576] RPC connection read error                err="read tcp 127.0.0.1:38875->127.0.0.1:36806: use of closed network connection"
INFO [01-09|09:38:40.576] HTTP server stopped                      endpoint=127.0.0.1:38875
DEBUG[01-09|09:38:40.576] RPC server shutting down
TRACE[01-09|09:38:40.576] P2P networking is spinning down
--- FAIL: TestStakersCooperative (10.79s)
TestMessageExtractionLayer_TxStreamerHandleReorg
Stack Traces | 27.650s run time
=== RUN   TestMessageExtractionLayer_TxStreamerHandleReorg
INFO [01-09|09:33:10.184] New Key                                  name=Owner Address=0x26E554a8acF9003b83495c7f45F06edCB803d4e3
INFO [01-09|09:33:10.184] New Key                                  name=Faucet Address=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A
WARN [01-09|09:33:10.184] invalid test database engine flag; using default provided= default=in-memory
WARN [01-09|09:33:10.184] invalid test database engine flag; using default provided= default=in-memory
WARN [01-09|09:33:10.184] Sequencer ReadFromTxQueueTimeout is higher than MaxBlockSpeed ReadFromTxQueueTimeout=1s MaxBlockSpeed=10ms
WARN [01-09|09:33:10.185] Sequencer ReadFromTxQueueTimeout is higher than MaxBlockSpeed ReadFromTxQueueTimeout=1s MaxBlockSpeed=10ms
WARN [01-09|09:33:10.185] invalid test database engine flag; using default provided= default=in-memory
=== PAUSE TestMessageExtractionLayer_TxStreamerHandleReorg
=== CONT  TestMessageExtractionLayer_TxStreamerHandleReorg
�[38;5;48;1myay!! we validated block 17 in 270.99ms�[0;0m
�[38;5;48;1myay!! we validated block 18 in 75.44ms�[0;0m
    common_test.go:728: BuildL1 deployConfig: DeployBold=true, DeployReferenceDAContracts=false
�[38;5;48;1myay!! we validated block 23 in 79.57ms�[0;0m
�[38;5;48;1myay!! we validated block 12 in 254.88ms�[0;0m
�[38;5;48;1myay!! we validated block 24 in 190.91ms�[0;0m
    message_extraction_layer_test.go:627: reorg was not detected by TransactionStreamer
--- FAIL: TestMessageExtractionLayer_TxStreamerHandleReorg (27.65s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 0.23810% with 419 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.49%. Comparing base (c37da31) to head (b60d38a).
⚠️ Report is 157 commits behind head on raul/mel-inbox-reading.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           raul/mel-inbox-reading    #4130       +/-   ##
===========================================================
+ Coverage                   19.66%   34.49%   +14.83%     
===========================================================
  Files                         394      471       +77     
  Lines                       49360    56668     +7308     
===========================================================
+ Hits                         9705    19549     +9844     
+ Misses                      37795    33687     -4108     
- Partials                     1860     3432     +1572     

@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review December 23, 2025 13:30
@ganeshvanahalli ganeshvanahalli changed the title [MEL] - Implement a Transaction Recorder for MEL Validation [MEL] - Implement a Transaction and Receipt Recorder for MEL Validation Dec 30, 2025
@ganeshvanahalli ganeshvanahalli self-requested a review December 30, 2025 12:17
@ganeshvanahalli ganeshvanahalli changed the base branch from raul/mel-inbox-reading to master January 5, 2026 16:16
@ganeshvanahalli ganeshvanahalli changed the base branch from master to raul/mel-inbox-reading January 5, 2026 16:16
@ganeshvanahalli ganeshvanahalli changed the title [MEL] - Implement a Transaction and Receipt Recorder for MEL Validation Implement a Transaction and Receipt Recorder for MEL Validation Jan 5, 2026
@ganeshvanahalli ganeshvanahalli merged commit 7d405e7 into raul/mel-inbox-reading Jan 9, 2026
13 checks passed
@ganeshvanahalli ganeshvanahalli deleted the raul/mel-tx-record branch January 9, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants