Fix expected surplus in sequencer #4038
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 4 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
alexandrosfilios
force-pushed
the
afilios/fix-expected-surplus
branch
from
64e9da2 to
6cb625f
Compare
| } else { | ||
| // l1GasPrice can be zero because of roundings, hence backlogCost is calculated separately | ||
| backlogFee := big.NewInt(backlogCallDataUnits) | ||
| backlogFee.Mul(backlogFee, blobFeePerByte) |
Contributor
There was a problem hiding this comment.
I don't have enough context to understand this line change. Could you please add a brief description?
Contributor
There was a problem hiding this comment.
now I look at the entire computation and not sure I get it.
can you add a comment with the full computation for computing backlog cost here?
Contributor
Author
There was a problem hiding this comment.
Sure! We want to capture two values: l1GasPrice and backlogCost. This is the code we had initially:
blobFeePerByte, _ := s.parentChain.BlobFeePerByte(ctx, header)
blobFeePerByte.Mul(blobFeePerByte, blobTxBlobGasPerBlob)
blobFeePerByte.Div(blobFeePerByte, usableBytesInBlob)
l1GasPrice = blobFeePerByte.Int64() / 16
backlogCost = (backlogCallDataUnits * blobFeePerByte.Int64()) / 16
This means:
l1GasPrice = (blobFeePerByte * blobTxBlobGasPerBlob) / (usableBytesInBlob * 16)
backlogCost = backlogCallDataUnits * (blobFeePerByte * blobTxBlobGasPerBlob) / (usableBytesInBlob * 16)
The problem here was that we divide with usableBytesInBlob too early and because of rounding, the value of blobFeePerByte becomes zero. Then even if we multiply with backlogCallDataUnits, it will still stay zero. The solution here was to multiply with backlogCallDataUnits before we divide. The problem here was that I forgot a line that multiplied with blobFeePerByte (the intention was to use it there as, well, this is why I had even extracted it outside of the if else).
tsahee
requested changes
Nov 26, 2025
| } else { | ||
| // l1GasPrice can be zero because of roundings, hence backlogCost is calculated separately | ||
| backlogFee := big.NewInt(backlogCallDataUnits) | ||
| backlogFee.Mul(backlogFee, blobFeePerByte) |
Contributor
There was a problem hiding this comment.
now I look at the entire computation and not sure I get it.
can you add a comment with the full computation for computing backlog cost here?
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4038 +/- ##
==========================================
- Coverage 33.35% 33.14% -0.21%
==========================================
Files 453 453
Lines 55536 55537 +1
==========================================
- Hits 18524 18409 -115
- Misses 33774 33922 +148
+ Partials 3238 3206 -32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.