arb_getL1Confirmations and arb_findBatchContainingBlock RPC APIs in Consensus side

[diegoximenes]

Resolves NIT-3558

Medium to long term goal is to remove GetL1Confirmations and FindBatchContainingBlock from NodeInterface.
In those methods NodeInterface relies on calling Consensus and the parent chain, introducing a circular dependency between Consensus and Execution.

For that, the first step, which is covered by this PR, is to also provide this functionality through arb_getL1Confirmations and arb_findBatchContainingBlock RPC APIs, that should be placed in the Consensus side.

This PR also adds call metrics to the respective NodeInterface methods, so we can track if those methods that will be removed at some time, are still called.

[github-actions]

❌ 162 Tests Failed:

Tests completed	Failed	Passed	Skipped
4456	162	4294	0

View the top 3 failed tests by shortest run time

TestBatchPosterParallel

Stack Traces | -0.000s run time

=== RUN   TestBatchPosterParallel
=== PAUSE TestBatchPosterParallel

TestDimLogNestedCall

Stack Traces | -0.000s run time

=== RUN   TestDimLogNestedCall
INFO [12-22|20:50:45.531] New Key                                  name=Owner          Address=0x26E554a8acF9003b83495c7f45F06edCB803d4e3
INFO [12-22|20:50:45.531] New Key                                  name=Faucet         Address=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A
WARN [12-22|20:50:45.531] invalid test database engine flag; using default provided= default=in-memory
DEBUG[12-22|20:50:45.531] test database scheme                     testDatabaseEngine=in-memory
WARN [12-22|20:50:45.531] invalid test database engine flag; using default provided= default=in-memory
DEBUG[12-22|20:50:45.531] test database scheme                     testDatabaseEngine=in-memory
WARN [12-22|20:50:45.531] Sequencer ReadFromTxQueueTimeout is higher than MaxBlockSpeed ReadFromTxQueueTimeout=1s MaxBlockSpeed=10ms
WARN [12-22|20:50:45.531] Sequencer ReadFromTxQueueTimeout is higher than MaxBlockSpeed ReadFromTxQueueTimeout=1s MaxBlockSpeed=10ms
WARN [12-22|20:50:45.531] invalid test database engine flag; using default provided= default=in-memory
DEBUG[12-22|20:50:45.531] test database scheme                     testDatabaseEngine=in-memory
=== PAUSE TestDimLogNestedCall

TestFinalityDataPushedFromConsensusToExecution

Stack Traces | -0.000s run time

=== RUN   TestFinalityDataPushedFromConsensusToExecution
INFO [12-22|20:50:45.515] New Key                                  name=Owner          Address=0x26E554a8acF9003b83495c7f45F06edCB803d4e3
INFO [12-22|20:50:45.515] New Key                                  name=Faucet         Address=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A
WARN [12-22|20:50:45.515] invalid test database engine flag; using default provided= default=in-memory
DEBUG[12-22|20:50:45.515] test database scheme                     testDatabaseEngine=in-memory
WARN [12-22|20:50:45.515] invalid test database engine flag; using default provided= default=in-memory
DEBUG[12-22|20:50:45.515] test database scheme                     testDatabaseEngine=in-memory
WARN [12-22|20:50:45.515] Sequencer ReadFromTxQueueTimeout is higher than MaxBlockSpeed ReadFromTxQueueTimeout=1s MaxBlockSpeed=10ms
WARN [12-22|20:50:45.515] Sequencer ReadFromTxQueueTimeout is higher than MaxBlockSpeed ReadFromTxQueueTimeout=1s MaxBlockSpeed=10ms
WARN [12-22|20:50:45.515] invalid test database engine flag; using default provided= default=in-memory
DEBUG[12-22|20:50:45.515] test database scheme                     testDatabaseEngine=in-memory
=== PAUSE TestFinalityDataPushedFromConsensusToExecution

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

[codecov]

Codecov Report

❌ Patch coverage is 16.84211% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.50%. Comparing base (1f915ab) to head (86cf460).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3985      +/-   ##
==========================================
- Coverage   33.64%   31.50%   -2.14%     
==========================================
  Files         453      453              
  Lines       55565    55594      +29     
==========================================
- Hits        18693    17516    -1177     
- Misses      33587    34888    +1301     
+ Partials     3285     3190      -95     

[MishkaRogachev]

I don’t have much context on this part of the codebase, but the changes look clean, the structure makes sense, and the tests seem to cover the changes