Skip to content

[2022.3] Fix Deprecated API Warning #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrevorDaschOculus wants to merge 1 commit into
base: 2022.3/oculus-app-spacewarp
Choose a base branch
from
Open

[2022.3] Fix Deprecated API Warning #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions Packages/com.unity.render-pipelines.universal/Runtime/Passes/OculusMotionVectorPass.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ public class OculusMotionVectorPass : ScriptableRenderPass
FilteringSettings m_FilteringSettings;
ProfilingSampler m_ProfilingSampler;

RenderTargetIdentifier motionVectorColorIdentifier;
RenderTargetIdentifier motionVectorDepthIdentifier;
RTHandle motionVectorColorHandle;
RTHandle motionVectorDepthHandle;

public OculusMotionVectorPass(string profilerTag, bool opaque, RenderPassEvent evt, RenderQueueRange renderQueueRange, LayerMask layerMask, StencilState stencilState, int stencilReference)
{
Expand All @@ -32,16 +32,16 @@ internal OculusMotionVectorPass(URPProfileId profileId, bool opaque, RenderPassE
}

public void Setup(
RenderTargetIdentifier motionVecColorIdentifier,
RenderTargetIdentifier motionVecDepthIdentifier)
RTHandle motionVecColorIdentifier,
RTHandle motionVecDepthIdentifier)
{
this.motionVectorColorIdentifier = motionVecColorIdentifier;
this.motionVectorDepthIdentifier = motionVecDepthIdentifier;
this.motionVectorColorHandle = motionVecColorIdentifier;
this.motionVectorDepthHandle = motionVecDepthIdentifier;
}

public override void OnCameraSetup(CommandBuffer cmd, ref RenderingData renderingData)
{
ConfigureTarget(motionVectorColorIdentifier, motionVectorDepthIdentifier);
ConfigureTarget(motionVectorColorHandle, motionVectorDepthHandle);
ConfigureClear(ClearFlag.All, Color.black);
}

Expand Down
17 changes: 13 additions & 4 deletions Packages/com.unity.render-pipelines.universal/Runtime/UniversalRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ public override int SupportedCameraStackingTypes()
RTHandle m_OpaqueColor;
RTHandle m_MotionVectorColor;
RTHandle m_MotionVectorDepth;
RTHandle m_XRMotionVectorTargetHandleAlias;

ForwardLights m_ForwardLights;
DeferredLights m_DeferredLights;
Expand Down Expand Up @@ -393,6 +394,7 @@ internal override void ReleaseRenderTargets()
m_OpaqueColor?.Release();
m_MotionVectorColor?.Release();
m_MotionVectorDepth?.Release();
m_XRMotionVectorTargetHandleAlias?.Release();
hasReleasedRTs = true;
}

Expand Down Expand Up @@ -960,12 +962,19 @@ public override void Setup(ScriptableRenderContext context, ref RenderingData re
#if !UNITY_EDITOR
if (cameraData.xr.motionVectorRenderTargetValid)
{
RenderTargetHandle motionVecHandle = new RenderTargetHandle(cameraData.xr.motionVectorRenderTarget);
var rtMotionId = motionVecHandle.Identifier();
rtMotionId = new RenderTargetIdentifier(rtMotionId, 0, CubemapFace.Unknown, -1);
RenderTargetIdentifier motionVecId = cameraData.xr.motionVectorRenderTarget;

if (m_XRMotionVectorTargetHandleAlias == null || m_XRMotionVectorTargetHandleAlias.nameID != motionVecId)
{
m_XRMotionVectorTargetHandleAlias?.Release();
m_XRMotionVectorTargetHandleAlias = RTHandles.Alloc(motionVecId);
}

// ID is the same since a RenderTexture encapsulates all the attachments, including both color+depth.
m_OculusMotionVecPass.Setup(rtMotionId, rtMotionId);
RTHandle mvColor = m_XRMotionVectorTargetHandleAlias;
RTHandle mvDepth = m_XRMotionVectorTargetHandleAlias;

m_OculusMotionVecPass.Setup(mvColor, mvDepth);
EnqueuePass(m_OculusMotionVecPass);
}
#endif
Expand Down