Resurrecting Sidebar Macros plugin.#1414
Conversation
jneilliii
left a comment
jneilliii
left a comment
There was a problem hiding this comment.
Please see code comments.
_data/update_check_overlays.yaml
Outdated
| pip: https://github.com/jneilliii/OctoPrint-MarlinSlider/archive/{target_version}.zip | ||
| macro: | ||
| user: apbarratt | ||
| pip: https://github.com/apbarratt/octoprint_sidebar_macros/archive/{target_version}.zip |
There was a problem hiding this comment.
I'm not sure if it's technically necessary, but you did change the name of the repo as well. I think you should add the following.
repo: octoprint_sidebar_macros
There was a problem hiding this comment.
With a less sleepy brain, I actually understood what this overlay file was doing and I've updated it now for all the update config stuff that's changed, including the Display Name too, which I'd changed to match how it was being shown on the plugin directory. Last night I also just sort of blindly copied how the telegram example was done, but this morning I've actually fixed the pip link to use the same as what I've got in the plugin, which specifically targets built releases, rather than source code archives defined by tag, which hopefully makes this safer for making sure folk only get code when I am satisfied it's ready for release :)
_plugins/macro.md
Outdated
| - Mikhail Poluboyarinov | ||
| - apbarratt |
There was a problem hiding this comment.
concerned about formatting here because of the spaces.
- Mikhail Poluboyarinov
- apbarratt
There was a problem hiding this comment.
Eugh, sorry, in one of my rounds of trying to get the formatting correct on the actual plugin, it went and made the macro.md all be quad-spaced. I hadn't noticed when I copy pasted it over. Fixed now.
_plugins/macro.md
Outdated
| - sidebar | ||
| - macros | ||
| - helpers | ||
| - gcode |
There was a problem hiding this comment.
same as above, extra spacing.
_plugins/macro.md
Outdated
| - url: /assets/img/plugins/macro/main.png | ||
| alt: Sidebar macros list | ||
| caption: Sidebar macros list |
_plugins/macro.md
Outdated
| octoprint: | ||
| - 1.4.0 | ||
| os: | ||
| - linux | ||
| - windows | ||
| - macos | ||
| - freebsd | ||
| python: ">=3.7,<4" |
|
@jacopotediosi you didn't have any security issues on your list for this plugin prior to these changes did you? I don't see anything that would hit your list normally, no API stuff, etc. |
|
@jneilliii yeah the source code both on old and new repository looks good to me, thanks for asking! |
|
All feedback addressed, ready for another round of review :) |
3 participants
What is the name of your plugin?
Sidebar Macros
What does your plugin do?
Adds buttons to trigger gcode macros to the ui.
Where can we find the source code of your plugin?
Originally, this plugin was found here: https://github.com/mike1pol/octoprint_macro
However, after becoming abandoned, I have forked it to here: https://github.com/apbarratt/octoprint_sidebar_macros
Was any kind of genAI (ChatGPT, Copilot etc) involved in creating this plugin?
Yes. Whilst I am a frontend developer myself, the bulk of this work involved comparing the original codebase with that of the latest cookie cutter scaffolding and bringing it all up to date to match. With so much back and forth comparison required, I chose to utilise ChatGPT Codex to assist me in the majority of this migration.
Is your plugin commercial in nature?
No
Does your plugin rely on some cloud services?
No
Further notes
I'd like to thank @mike1pol for their original plugin and of course will be happy to submit any changes as a PR back to their repo should they ever wish to take on maintenance again in the future :)
resolves #1362