core/fetcher: update blinded gauge metric values #4170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4170 +/- ##
==========================================
+ Coverage 56.29% 56.34% +0.04%
==========================================
Files 245 245
Lines 31246 31246
==========================================
+ Hits 17591 17604 +13
+ Misses 11337 11329 -8
+ Partials 2318 2313 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
KaloyanTanev
approved these changes
Dec 12, 2025
DiogoSantoss
added
the
merge when ready
DiogoSantoss
added a commit
that referenced
this pull request
Dec 12, 2025
Previously `core_fetcher_proposal_blinded` had values 0 (local) or 1 (blinded). This is problematic because the default value for the gauge is also zero so when a node starts/restarts it reports a 0 value before fetching any block which makes monitoring more complicated. This updates the values to be 2 (local) and 1 (blinded) category: bug ticket: none
DiogoSantoss
added a commit
that referenced
this pull request
Dec 12, 2025
Previously `core_fetcher_proposal_blinded` had values 0 (local) or 1 (blinded). This is problematic because the default value for the gauge is also zero so when a node starts/restarts it reports a 0 value before fetching any block which makes monitoring more complicated. This updates the values to be 2 (local) and 1 (blinded) category: bug ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
core_fetcher_proposal_blindedhad values 0 (local) or 1 (blinded). This is problematic because the default value for the gauge is also zero so when a node starts/restarts it reports a 0 value before fetching any block which makes monitoring more complicated.This updates the values to be 2 (local) and 1 (blinded)
category: bug
ticket: none