Open
Conversation
|
@stankut will you please add jekuaitk as reviewer on this pr? |
jekuaitk
requested changes
Apr 7, 2026
| ->format('Y-m-d\T00:00:00\Z'); | ||
|
|
||
| $query = <<<GRAPHQL | ||
| { CVR_Virksomhed(first: 1, virkningstid: "{$virkningstid}", where: { CVRNummer: { eq: {$cvr} } }) { |
Contributor
There was a problem hiding this comment.
Should we ensure/validate that this is indeed a CVR-number, i.e. 8 digits?
Comment on lines
8
to
+9
| ## [Unreleased] | ||
| * Datafordeler CRV service endpoint update - GraphQL. |
Contributor
There was a problem hiding this comment.
Suggested change
| ## [Unreleased] | |
| * Datafordeler CRV service endpoint update - GraphQL. | |
| ## [Unreleased] | |
| * Datafordeler CVR service endpoint update - GraphQL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
OS2Forms/os2forms#248
Description
Replacing the existing Datafordeler endpoint with a new endpoint based on GraphQL.
Additional comments or questions
This is a new of a kind Datafordeler webservice integration that is based on API key, and not the certificate as it used to.
That is why the architecture is changed a bit. Bear in mind, I deliberately decided not do put anything if the parent class and wait until have more example of the new Datafordeler webservices. After that the pattern will be more prominent, which will allow us to move the repetitive/shared features into the parent class