Event system proposed edits + File format#363
Event system proposed edits + File format#363lukelowry wants to merge 4 commits intoPhilipFackler/generic_pdsimfrom
Conversation
|
I understand rationale for this suggestion but have slightly different view how to go about this:
This division is based on which part of the software is processing what information. The case (model specification) file is processed by the system model constructor, so all the information affecting the model should stay in that file imho. The solver configuration (study) file is processed by the application instantiating the solver and configuring the simulation. That file should not contain information related to modifying/configuring the model. |
pelesh
left a comment
There was a problem hiding this comment.
I would keep monitors specification in the case file.
|
Thank you for the feedback. I agree with you regarding the boundary of the model and runner. I have a few motivating concerns regarding a future consumer's workflow when using a GK App:
I agree with you, however. Is adding a third input layer for monitoring a poor design direction? Conceptually, I have thought of the monitors as a 'telemetry' or observation tool for the user to measure the model, rather than as part of the model itself. Let me know your thoughts. I am happy to go in either direction. Thanks! |
d7a8214 to
af8d3eb
Compare
Attempting to do a stacked PR on top of @PhilipFacklers changes because they are useful for my other WIP!
Changes
monitorsinto the study file specification as opposed to theINPUT_FORMAT.mdstudyfile formatPDsimappBusFaultsout of file format for case and into the study file.The individual
monfields I believe, should remain in the case file format, but the output sink parameters should be a study/runner level parameter