[18.0][FIX] dbs value has to be kept in case of special proxy config#3475
Open
[18.0][FIX] dbs value has to be kept in case of special proxy config#3475
Conversation
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Point of order: please include the module name in the commit and PR title, as in [FIX] dbfilter_from_header: keep dbs value in case of special proxy config.
On the 17.0 PR (#3261), someone mentions that this causes a regression wrt their combined use of both dbfilter and dbfilter_from_header. We need to discuss the pros and cons of each approach. To help with this, @cvinh can you add a test case to illustrate what issue this change solves for you?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit has been merged for v14 and v16 but still pending for v17