Skip to content

[FIX]report_py3o:_format_lang function#1074

Merged
OCA-git-bot merged 1 commit intoOCA:18.0from
acsone:fix-report_py3o
Jan 29, 2026
Merged

[FIX]report_py3o:_format_lang function#1074
OCA-git-bot merged 1 commit intoOCA:18.0from
acsone:fix-report_py3o

Conversation

@bjouini-acsone
Copy link
Copy Markdown
Contributor

No description provided.

@qgroulard
Copy link
Copy Markdown

Could you please provide a bit of context ?

@bjouini-acsone
Copy link
Copy Markdown
Contributor Author

Could you please provide a bit of context ?

@qgroulard added to the commit

@qgroulard
Copy link
Copy Markdown

I see, then we can also remove monetary from the function signature since it's not used anymore.

@bjouini-acsone
Copy link
Copy Markdown
Contributor Author

I see, then we can also remove monetary from the function signature since it's not used anymore.

yes you are right , removed

@qgroulard
Copy link
Copy Markdown

Pay also attention to where this method is called.

the param monetary on formatLang used in fomatted_value variable in deprecated since v13 ,
and it causes a stacktrace on report generation
@bjouini-acsone
Copy link
Copy Markdown
Contributor Author

Pay also attention to where this method is called.

done

Copy link
Copy Markdown

@baimont baimont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review, lgtm

Copy link
Copy Markdown

@qgroulard qgroulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too 👍

@HviorForgeFlow
Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1074-by-HviorForgeFlow-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cef50e6 into OCA:18.0 Jan 29, 2026
6 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at a20e349. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants