[19.0][MIG] sale_project_copy_tasks: Migration to 19.0#1646
[19.0][MIG] sale_project_copy_tasks: Migration to 19.0#1646bizzappdev wants to merge 8 commits intoOCA:19.0from
Conversation
Without this patch, upgrading the addon raises this error:
Field 'partner_id' used in context ({'default_partner_id': partner_id, 'default_sale_order_id': active_id}) must be present in view but is missing.
@moduon MT-3426
…d always This reverts OCA#1416 and adds instead a different, more accurate fix for the problem (which kept yielding different errors). The main source of problem is that the same view is adding a `project_id` field and editing another `project_id` fields' attributes. For this reason, installing the module didn't give any problems, but updating it was problematic. The new field appeared above in the view hierarchy than the old one. The xpath for the old one was less specific than necessary, and then found the new one instead. The new one is within a tree subview, so the model is different (`sale.order.line` instead of `sale.order`). Thus the fields exposed to that field are different, and failures happened a bit randomly. @moduon MT-3426
|
Runboat is not available for testing. Is something wrong? |
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Thanks for taking this on. The copy_tasks_in_project service tracking type is well implemented — product template, sale order, and sale order line extensions all look good. Clean migration. LGTM.
|
This PR has the |
|
/ocabot migration sale_project_copy_tasks |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
@leemannd your merge command was aborted due to failed check(s), which you can inspect on this commit of 19.0-ocabot-merge-pr-1646-by-leemannd-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
9 participants
No description provided.