Skip to content

Conversation

@github-actions
Copy link
Contributor

This pull request changes the compat entry for the PrettyTables package from 2.4.0 to 2.4.0, 3 for package docs.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@SKopecz SKopecz force-pushed the compathelper/new_version/2025-08-26-00-30-21-064-01675844121 branch from dc628df to b382047 Compare August 26, 2025 00:30
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coveralls
Copy link

coveralls commented Aug 26, 2025

Pull Request Test Coverage Report for Build 17949600100

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.768%

Totals Coverage Status
Change from base Build 17949581903: 0.0%
Covered Lines: 1971
Relevant Lines: 2016

💛 - Coveralls

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PrettyTables.jl v3 changed the API completely. We have to adapt the code to allow it.

Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
@JoshuaLampert
Copy link
Member

So now the formatting looks good again, but for some reason PrettyTables.jl prefers to omit some columns instead of creating a scrollbar. I don't know how to fix that.

@SKopecz
Copy link
Collaborator

SKopecz commented Sep 19, 2025

I'd suggest to show tables with less columns. I didn't think much of the scroll bar anyway.

Need to check if three or four schemes fit in one table.

Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I would like to see whether Documenter builds the docs correctly with this commit. The previous build failed for some reason...

@JoshuaLampert
Copy link
Member

I think, https://numericalmathematics.github.io/PositiveIntegrators.jl/previews/PR169/convergence/ should display the most recent version in this PR.

@ranocha
Copy link
Member

ranocha commented Sep 24, 2025

Thanks! I would like to see if Documenter works this time or if there is an issue we need to fix.

@JoshuaLampert
Copy link
Member

Thanks! I would like to see if Documenter works this time or if there is an issue we need to fix.

Now the docs were built successfully 🥳

@ranocha ranocha merged commit 4db47f5 into main Sep 25, 2025
11 checks passed
@ranocha ranocha deleted the compathelper/new_version/2025-08-26-00-30-21-064-01675844121 branch September 25, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants