-
Notifications
You must be signed in to change notification settings - Fork 6
CompatHelper: bump compat for PrettyTables to 3 for package docs, (keep existing compat) #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for PrettyTables to 3 for package docs, (keep existing compat) #169
Conversation
…ep existing compat)
dc628df to
b382047
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Pull Request Test Coverage Report for Build 17949600100Details
💛 - Coveralls |
ranocha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PrettyTables.jl v3 changed the API completely. We have to adapt the code to allow it.
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
|
So now the formatting looks good again, but for some reason PrettyTables.jl prefers to omit some columns instead of creating a scrollbar. I don't know how to fix that. |
|
I'd suggest to show tables with less columns. I didn't think much of the scroll bar anyway. Need to check if three or four schemes fit in one table. |
JoshuaLampert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
ranocha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I would like to see whether Documenter builds the docs correctly with this commit. The previous build failed for some reason...
|
I think, https://numericalmathematics.github.io/PositiveIntegrators.jl/previews/PR169/convergence/ should display the most recent version in this PR. |
|
Thanks! I would like to see if Documenter works this time or if there is an issue we need to fix. |
Now the docs were built successfully 🥳 |
This pull request changes the compat entry for the
PrettyTablespackage from2.4.0to2.4.0, 3for package docs.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.