-
Notifications
You must be signed in to change notification settings - Fork 6
repository transfer #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
repository transfer #156
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
There is one work-precision fixed: Test Failed at /Users/runner/work/PositiveIntegrators.jl/PositiveIntegrators.jl/test/runtests.jl:2594
Expression: maximum((v .- m1) ./ m1) < 2.5
Evaluated: 8.10910718891217 < 2.5If I recall correctly, we had issues with I see two possibilities:
So I would vote for Option 1. |
SKopecz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please see #156 (comment).
|
Good point. I made a change as suggested in the last commit. |
SKopecz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
JoshuaLampert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I updated the URL accordingly. I also bumped the version number so that we can check the registration process.
I also relaxed the work-precision time tests since they failed sometimes, e.g., in https://github.com/NumericalMathematics/PositiveIntegrators.jl/actions/runs/14188778930/job/39748822294#step:6:848. I have seen this a few times before and it is annoying to have to restart the CI jobs just because of this.