On error the encoder/decoder now emit everything it was able to decode.#454
Merged
NobodyXu merged 1 commit intoNullus157:mainfrom Feb 24, 2026
Merged
Conversation
orium
force-pushed
the
gzip-do-not-swallow-on-missing-footer
branch
from
98d2873 to
31a4e72
Compare
orium
changed the title
orium
changed the title
orium
force-pushed
the
gzip-do-not-swallow-on-missing-footer
branch
from
31a4e72 to
8fde492
Compare
Contributor
Author
|
Blocked on #456. |
orium
force-pushed
the
gzip-do-not-swallow-on-missing-footer
branch
from
8fde492 to
e1aeab3
Compare
orium
changed the title
…e/decode. Before this we would return the error and whatever we had in our encode/decoded output buffer would be swallowed. Fixes Nullus157#453.
orium
force-pushed
the
gzip-do-not-swallow-on-missing-footer
branch
from
e1aeab3 to
3ccadbe
Compare
Contributor
Author
|
Rebased on main. Ready for review @NobodyXu. |
Contributor
Author
|
Hi @robjtede, can you take a look at this one as well please? |
Contributor
Author
|
@NobodyXu Is there anyone else that can review so this can land? |
Collaborator
Well I was just being careful as last time I land a PR which turns out to be have some issues I looked at this PR again and is very sure it is good, so I'd merge it and cut a release |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this we would return the error and whatever we had in our encode/decoded output buffer would be swallowed.