Skip to content

Conversation

@William-Laverty
Copy link

Summary

Fixes #90

Updates the project structure documentation to accurately reflect the current source files, following the checklist provided in the issue.

Changes

✅ 1. Consolidated duplicate PROJECT_STRUCTURE.md files

  • Removed /MiddleDrag/PROJECT_STRUCTURE.md (the inner, outdated one)
  • Root /PROJECT_STRUCTURE.md is now the single canonical version

✅ 2. Added missing source files to documentation

Core/

  • TouchDeviceProviding.swift: Protocol for device monitoring and dependency injection

Managers/

  • AccessibilityMonitor.swift: Accessibility permission polling and app handling
  • AccessibilityWrappers.swift: Wrappers for accessibility system APIs (enables testability)

Utilities/

  • ScreenHelper.swift: Multi-monitor screen coordinate handling (Cocoa ↔ Quartz)
  • SystemGestureHelper.swift: System trackpad settings and process management
  • UpdateManager.swift: App updates via Sparkle framework (offline by default)
  • WindowHelper.swift: Window detection under cursor

Additional improvements

  • Added all unit test files to documentation
  • Added Mocks/ directory with MockDeviceMonitor.swift
  • Updated "Component Responsibilities" section with new components
  • Added "Protocol-Oriented Design" to design patterns
  • Updated "Adding New Features" section with new entry points
  • Minor formatting improvements for consistency

Fixes NullPointerDepressiveDisorder#90

## Changes

### Added missing files to documentation:

**Core/**
- TouchDeviceProviding.swift: Protocol for device monitoring/dependency injection

**Managers/**
- AccessibilityMonitor.swift: Accessibility permission polling and app handling
- AccessibilityWrappers.swift: Wrappers for accessibility system APIs (testability)

**Utilities/**
- ScreenHelper.swift: Multi-monitor screen coordinate handling
- SystemGestureHelper.swift: System trackpad settings and process management
- UpdateManager.swift: App updates via Sparkle framework
- WindowHelper.swift: Window detection under cursor

### Added test files to documentation:
- All unit test files now documented
- Added Mocks/ directory with MockDeviceMonitor

### Consolidation:
- Removed duplicate /MiddleDrag/PROJECT_STRUCTURE.md (root version is canonical)

### Updated component responsibilities:
- Added descriptions for new Manager layer components
- Added descriptions for new Utility layer components
- Added Protocol-Oriented Design to design patterns
- Updated "Adding New Features" section with new entry points
Copilot AI review requested due to automatic review settings February 2, 2026 09:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates PROJECT_STRUCTURE.md to accurately reflect the current codebase structure, addressing issue #90.

Changes:

  • Consolidated duplicate PROJECT_STRUCTURE.md files by removing the outdated inner copy
  • Added documentation for 7 missing source files across Core/, Managers/, and Utilities/ directories
  • Expanded test section from 3 files to all 17 test files including the Mocks/ directory

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
PROJECT_STRUCTURE.md Updated with all current source files, complete test listing, expanded component responsibilities, and updated design patterns
MiddleDrag/PROJECT_STRUCTURE.md Removed duplicate outdated documentation file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

├── workflows/ # CI/CD workflows
│ └── *.yml # GitHub Actions workflow files
├── ISSUE_TEMPLATE/ # Issue templates
└── copilot-instructions.md # Copilot configuration
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference to copilot-instructions.md should be removed as this file doesn't exist in the repository. This was specifically mentioned in checklist item #4 of issue #90: "Remove mention of .github/copilot-instructions.md from the .github/ section (file doesn't exist)". The line should be deleted entirely.

Suggested change
└── copilot-instructions.md # Copilot configuration

Copilot uses AI. Check for mistakes.

The refactored code maintains minimal dependencies:
- No external Swift packages required
- No external Swift packages required (except Sparkle for updates)
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependencies documentation is incomplete. The project uses both Sparkle (for updates) and Sentry (for analytics/error reporting) as external packages, but only Sparkle is mentioned. The line should be updated to mention both dependencies, for example: "No external Swift packages required (except Sparkle for updates and Sentry for analytics)".

Suggested change
- No external Swift packages required (except Sparkle for updates)
- No external Swift packages required (except Sparkle for updates and Sentry for analytics/error reporting)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update PROJECT_STRUCTURE.md to reflect current codebase

1 participant