Fix: Multitouch stability during rapid system changes#113
Merged
NullPointerDepressiveDisorder merged 3 commits intomainfrom Feb 21, 2026
Merged
Fix: Multitouch stability during rapid system changes#113NullPointerDepressiveDisorder merged 3 commits intomainfrom
NullPointerDepressiveDisorder merged 3 commits intomainfrom
Conversation
Copilot started reviewing on behalf of
NullPointerDepressiveDisorder
February 21, 2026 07:52
View session
Contributor
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses multitouch stability issues during rapid system changes by increasing timeout delays and adding safety checks. The changes aim to prevent race conditions and crashes (CFRelease(NULL), EXC_BREAKPOINT) that occur when the MultitouchSupport framework's internal thread interacts with device lifecycle operations during rapid connectivity changes or system state transitions.
Changes:
- Increased
restartCleanupDelayfrom 0.5s to 1.0s (100% increase) andminimumRestartIntervalfrom 0.6s to 2.5s (316% increase) to provide more time for framework cleanup - Added redundant safety check in device callback to verify monitor is still running
- Updated test timeouts and assertion thresholds to match new delay values
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| MiddleDrag/Managers/MultitouchManager.swift | Doubled restartCleanupDelay to 1.0s and increased minimumRestartInterval to 2.5s; removed empirical evidence comments |
| MiddleDrag/Managers/DeviceMonitor.swift | Doubled frameworkCleanupDelay to 1.0s; added redundant isRunning check in callback; changed access modifiers to fileprivate |
| MiddleDrag/MiddleDragTests/MultitouchManagerTests.swift | Increased test timeouts from 1.0s to 3.0s, 2.0s to 5.0s, 3.0s to 5.0s; updated assertion thresholds for delay constants |
| MiddleDrag/MiddleDragTests/DeviceMonitorTests.swift | Updated frameworkCleanupDelay assertion threshold from 0.5s to 1.0s |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Karan Mohindroo <96403086+NullPointerDepressiveDisorder@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Karan Mohindroo <96403086+NullPointerDepressiveDisorder@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issues
Testing Performed
Checklist
Code Coverage
Screenshots / Recordings
Additional Notes